You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/12 08:57:01 UTC
[GitHub] [apisix] Firstsawyou opened a new pull request #4033: docs: improve the prometheus docs
Firstsawyou opened a new pull request #4033:
URL: https://github.com/apache/apisix/pull/4033
close #3973
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
Update the Dashboard picture in the Prometheus documentation and remove the access address of the old version of the Dashboard.
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #4033: docs: improve the prometheus docs
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #4033:
URL: https://github.com/apache/apisix/pull/4033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #4033: docs: improve the prometheus docs
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #4033:
URL: https://github.com/apache/apisix/pull/4033#discussion_r611464563
##########
File path: docs/zh/latest/plugins/prometheus.md
##########
@@ -80,7 +80,9 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f13
}'
```
-你可以使用浏览器打开 dashboard：`http://127.0.0.1:9080/apisix/dashboard/`，通过 web 界面来完成上面的操作，先增加一个 route：
+你可以使用 [APISIX Dashboard](https://github.com/apache/apisix-dashboard) 通过 web 界面来完成上面的操作。
+
+先增加一个 route：
Review comment:
```suggestion
先增加一个 Route：
```
##########
File path: docs/en/latest/plugins/prometheus.md
##########
@@ -80,7 +80,9 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f1
}'
```
-You can open dashboard with a browser: `http://127.0.0.1:9080/apisix/dashboard/`, to complete the above operation through the web interface, first add a route:
+You can use [APISIX Dashboard](https://github.com/apache/apisix-dashboard) to complete the above operations through the web console.
+
+First add a route:
Review comment:
```suggestion
First, add a Route:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org