[jira] [Commented] (OFBIZ-12576) Change common webapp to common-theme

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-12576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507522#comment-17507522 ] 

ASF subversion and git services commented on OFBIZ-12576:
---------------------------------------------------------

Commit 8a6502b2ff9604c17d93e7fb71e5fb990af256bb in ofbiz-tools's branch refs/heads/master from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-tools.git;h=8a6502b ]

Improved: Change common webapp to common-theme (OFBIZ-12576)

Missed these changes one month ago


> Change common webapp to common-theme
> ------------------------------------
>
>                 Key: OFBIZ-12576
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12576
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: themes
>    Affects Versions: Upcoming Branch
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: Upcoming Branch
>
>         Attachments: Image 001.png
>
>
> Currently the ofbiz-component.xml in themes refers to 2 webapps common-theme and images. The location of the former is location="webapp/common". At least on my machine this creates, or has created, a local only common directory under themes !Image 001.png! At some points (some months ago IIRW) I had to add a bunch of .gitgnore files unders subdirs of this local only common directory.
> I think it's better to have the location of the common-theme webapp at webapp/common-theme. Hence the possible local only common directory under themes  disappears. Backend and frontend work fine. It's just some rename so should be easy to revert if ever I miss something. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)