You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/01/31 23:02:12 UTC
Review Request 17621: Refactored io::splice for C++03.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17621/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/src/process.cpp 1083a35a0fef48d5f790ec49305a56fd7ef451d5
Diff: https://reviews.apache.org/r/17621/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 17621: Refactored io::splice for C++03.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17621/#review33370
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/17621/#comment62829>
This promise does not seem "Owned" since we're binding it in multiple places, did you feel that since only one callback will operate on it, it is effectively "Owned"?
- Ben Mahler
On Jan. 31, 2014, 10:02 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17621/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2014, 10:02 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 1083a35a0fef48d5f790ec49305a56fd7ef451d5
>
> Diff: https://reviews.apache.org/r/17621/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>