[GitHub] [spark] stczwd edited a comment on pull request #28617: [SPARK-31694][SQL] Add SupportsPartitions Catalog APIs on DataSourceV2

[GitBox <gi...@apache.org>]

stczwd edited a comment on pull request #28617:
URL: https://github.com/apache/spark/pull/28617#issuecomment-663474659


   @rdblue Thanks for your attention and advices. It would be great if we can have this in 3.1, a lots of things can be done after `Partition API` defined.
   Your points are all reasonable to me, thanks for your help. I will reconsider about the partition methods.
   
   BTW, the reason using `parameters` to contains partition metadata is to suit other sources, like mysql. They may have other kind of metadata for partition. As for other sources which does not have partition metadata, the can use `TablePartition` with partition identifier as well, the `parameters` can be an empty map.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org