You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Andres March (JIRA)" <ji...@codehaus.org> on 2006/03/09 21:16:22 UTC
[jira] Created: (MWAR-26) Do not overwrite target unless source is
modified
Do not overwrite target unless source is modified
-------------------------------------------------
Key: MWAR-26
URL: http://jira.codehaus.org/browse/MWAR-26
Project: Maven 2.x War Plugin
Type: Bug
Reporter: Andres March
I thought MWAR-8 had fixed my issue but it seems to still exist. Correct me if I'm wrong but doing incremental builds with this war plugin is not possible. All the web app sources get overwritten regardless if they have been modified or not. Incremental build were possible in Maven 1 because it was ANT based. This version uses plexus FileUtils which overwrites without regard to if the target file exists or older than the source. Besides the time issue, overwriting the web.xml each time makes my context reload since the context runs on tomcat from the target location. I think this is a reasonable configuration but if there is a better way, let me know. Building inplace wars is not an option as it dirties the source.
If we are in agreement, I may be able to provide a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MWAR-26) Do not overwrite target unless source is
modified
Posted by "John Tolentino (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-26?page=all ]
John Tolentino updated MWAR-26:
-------------------------------
Attachment: MWAR-26-maven-war-plugin.diff
> Do not overwrite target unless source is modified
> -------------------------------------------------
>
> Key: MWAR-26
> URL: http://jira.codehaus.org/browse/MWAR-26
> Project: Maven 2.x War Plugin
> Type: Bug
> Reporter: Andres March
> Assignee: John Tolentino
> Fix For: 2.0
> Attachments: MWAR-26-maven-war-plugin.diff
>
> Time Spent: 1 hour, 40 minutes
> Remaining: 0 minutes
>
> I thought MWAR-8 had fixed my issue but it seems to still exist. Correct me if I'm wrong but doing incremental builds with this war plugin is not possible. All the web app sources get overwritten regardless if they have been modified or not. Incremental build were possible in Maven 1 because it was ANT based. This version uses plexus FileUtils which overwrites without regard to if the target file exists or older than the source. Besides the time issue, overwriting the web.xml each time makes my context reload since the context runs on tomcat from the target location. I think this is a reasonable configuration but if there is a better way, let me know. Building inplace wars is not an option as it dirties the source.
> If we are in agreement, I may be able to provide a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MWAR-26) Do not overwrite target unless source is
modified
Posted by "Edwin Punzalan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-26?page=all ]
Edwin Punzalan closed MWAR-26:
------------------------------
Resolution: Fixed
Patch applied. Thanks.
> Do not overwrite target unless source is modified
> -------------------------------------------------
>
> Key: MWAR-26
> URL: http://jira.codehaus.org/browse/MWAR-26
> Project: Maven 2.x War Plugin
> Type: Bug
> Reporter: Andres March
> Assignee: John Tolentino
> Fix For: 2.0
> Attachments: MWAR-26-maven-war-plugin-2.diff, MWAR-26-maven-war-plugin.diff
>
> Time Spent: 3 hours, 40 minutes
> Remaining: 0 minutes
>
> I thought MWAR-8 had fixed my issue but it seems to still exist. Correct me if I'm wrong but doing incremental builds with this war plugin is not possible. All the web app sources get overwritten regardless if they have been modified or not. Incremental build were possible in Maven 1 because it was ANT based. This version uses plexus FileUtils which overwrites without regard to if the target file exists or older than the source. Besides the time issue, overwriting the web.xml each time makes my context reload since the context runs on tomcat from the target location. I think this is a reasonable configuration but if there is a better way, let me know. Building inplace wars is not an option as it dirties the source.
> If we are in agreement, I may be able to provide a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-26) Do not overwrite target unless source
is modified
Posted by "Andres March (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-26?page=comments#action_60915 ]
Andres March commented on MWAR-26:
----------------------------------
This will be a significant patch, since FileUtils currently does all the copying. I will have a go at it and see if I can put something together. Is there any common apache or codehaus libraries that have this type of "copy only if modified" feature?
> Do not overwrite target unless source is modified
> -------------------------------------------------
>
> Key: MWAR-26
> URL: http://jira.codehaus.org/browse/MWAR-26
> Project: Maven 2.x War Plugin
> Type: Bug
> Reporter: Andres March
> Fix For: 2.0
>
>
> I thought MWAR-8 had fixed my issue but it seems to still exist. Correct me if I'm wrong but doing incremental builds with this war plugin is not possible. All the web app sources get overwritten regardless if they have been modified or not. Incremental build were possible in Maven 1 because it was ANT based. This version uses plexus FileUtils which overwrites without regard to if the target file exists or older than the source. Besides the time issue, overwriting the web.xml each time makes my context reload since the context runs on tomcat from the target location. I think this is a reasonable configuration but if there is a better way, let me know. Building inplace wars is not an option as it dirties the source.
> If we are in agreement, I may be able to provide a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MWAR-26) Do not overwrite target unless source is
modified
Posted by "John Tolentino (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-26?page=all ]
John Tolentino updated MWAR-26:
-------------------------------
Attachment: (was: MWAR-26-maven-war-plugin-2.diff)
> Do not overwrite target unless source is modified
> -------------------------------------------------
>
> Key: MWAR-26
> URL: http://jira.codehaus.org/browse/MWAR-26
> Project: Maven 2.x War Plugin
> Type: Bug
> Reporter: Andres March
> Assignee: John Tolentino
> Fix For: 2.0
> Attachments: MWAR-26-maven-war-plugin.diff
>
> Time Spent: 3 hours, 40 minutes
> Remaining: 0 minutes
>
> I thought MWAR-8 had fixed my issue but it seems to still exist. Correct me if I'm wrong but doing incremental builds with this war plugin is not possible. All the web app sources get overwritten regardless if they have been modified or not. Incremental build were possible in Maven 1 because it was ANT based. This version uses plexus FileUtils which overwrites without regard to if the target file exists or older than the source. Besides the time issue, overwriting the web.xml each time makes my context reload since the context runs on tomcat from the target location. I think this is a reasonable configuration but if there is a better way, let me know. Building inplace wars is not an option as it dirties the source.
> If we are in agreement, I may be able to provide a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Reopened: (MWAR-26) Do not overwrite target unless source is
modified
Posted by "John Tolentino (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-26?page=all ]
John Tolentino reopened MWAR-26:
--------------------------------
Maven 2.0.3 uses plexus-utils-1.1.jar in its lib. This overrides the version used in maven-war-plugin (which is version 1.2-SNAPSHOT) for this patch. Please revert until Maven 2 moves to version 1.2 of plexus-utils.
> Do not overwrite target unless source is modified
> -------------------------------------------------
>
> Key: MWAR-26
> URL: http://jira.codehaus.org/browse/MWAR-26
> Project: Maven 2.x War Plugin
> Type: Bug
> Reporter: Andres March
> Assignee: John Tolentino
> Fix For: 2.0
> Attachments: MWAR-26-maven-war-plugin-2.diff, MWAR-26-maven-war-plugin.diff
>
> Time Spent: 3 hours, 40 minutes
> Remaining: 0 minutes
>
> I thought MWAR-8 had fixed my issue but it seems to still exist. Correct me if I'm wrong but doing incremental builds with this war plugin is not possible. All the web app sources get overwritten regardless if they have been modified or not. Incremental build were possible in Maven 1 because it was ANT based. This version uses plexus FileUtils which overwrites without regard to if the target file exists or older than the source. Besides the time issue, overwriting the web.xml each time makes my context reload since the context runs on tomcat from the target location. I think this is a reasonable configuration but if there is a better way, let me know. Building inplace wars is not an option as it dirties the source.
> If we are in agreement, I may be able to provide a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-26) Do not overwrite target unless source
is modified
Posted by "John Tolentino (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-26?page=comments#action_61081 ]
John Tolentino commented on MWAR-26:
------------------------------------
Almost done but still doing unit tests. Will definitely have a patch ready by tomorrow.
> Do not overwrite target unless source is modified
> -------------------------------------------------
>
> Key: MWAR-26
> URL: http://jira.codehaus.org/browse/MWAR-26
> Project: Maven 2.x War Plugin
> Type: Bug
> Reporter: Andres March
> Assignee: John Tolentino
> Fix For: 2.0
>
>
> I thought MWAR-8 had fixed my issue but it seems to still exist. Correct me if I'm wrong but doing incremental builds with this war plugin is not possible. All the web app sources get overwritten regardless if they have been modified or not. Incremental build were possible in Maven 1 because it was ANT based. This version uses plexus FileUtils which overwrites without regard to if the target file exists or older than the source. Besides the time issue, overwriting the web.xml each time makes my context reload since the context runs on tomcat from the target location. I think this is a reasonable configuration but if there is a better way, let me know. Building inplace wars is not an option as it dirties the source.
> If we are in agreement, I may be able to provide a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-26) Do not overwrite target unless source
is modified
Posted by "John Tolentino (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-26?page=comments#action_61556 ]
John Tolentino commented on MWAR-26:
------------------------------------
Maven 2.0.3 was already voted on for release. That email was sent by John Casey to maven developers list, subject is [vote] Release Maven 2.0.3 (third RC).
So the libraries used in that 2.0.3 won't have any more changes. There will still be a patch for maven-war-plugin in time for its 2.0 release though. Instead of having the code in plexus-utils, it will be in the war plugin. We'll just have to apply the first patch when maven changes the plexus-utils version that it uses to 1.2.
> Do not overwrite target unless source is modified
> -------------------------------------------------
>
> Key: MWAR-26
> URL: http://jira.codehaus.org/browse/MWAR-26
> Project: Maven 2.x War Plugin
> Type: Bug
> Reporter: Andres March
> Assignee: John Tolentino
> Fix For: 2.0
> Attachments: MWAR-26-maven-war-plugin-2.diff, MWAR-26-maven-war-plugin.diff
>
> Time Spent: 3 hours, 40 minutes
> Remaining: 0 minutes
>
> I thought MWAR-8 had fixed my issue but it seems to still exist. Correct me if I'm wrong but doing incremental builds with this war plugin is not possible. All the web app sources get overwritten regardless if they have been modified or not. Incremental build were possible in Maven 1 because it was ANT based. This version uses plexus FileUtils which overwrites without regard to if the target file exists or older than the source. Besides the time issue, overwriting the web.xml each time makes my context reload since the context runs on tomcat from the target location. I think this is a reasonable configuration but if there is a better way, let me know. Building inplace wars is not an option as it dirties the source.
> If we are in agreement, I may be able to provide a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MWAR-26) Do not overwrite target unless source is
modified
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-26?page=all ]
Brett Porter updated MWAR-26:
-----------------------------
Fix Version: 2.0
would be a good addition.
> Do not overwrite target unless source is modified
> -------------------------------------------------
>
> Key: MWAR-26
> URL: http://jira.codehaus.org/browse/MWAR-26
> Project: Maven 2.x War Plugin
> Type: Bug
> Reporter: Andres March
> Fix For: 2.0
>
>
> I thought MWAR-8 had fixed my issue but it seems to still exist. Correct me if I'm wrong but doing incremental builds with this war plugin is not possible. All the web app sources get overwritten regardless if they have been modified or not. Incremental build were possible in Maven 1 because it was ANT based. This version uses plexus FileUtils which overwrites without regard to if the target file exists or older than the source. Besides the time issue, overwriting the web.xml each time makes my context reload since the context runs on tomcat from the target location. I think this is a reasonable configuration but if there is a better way, let me know. Building inplace wars is not an option as it dirties the source.
> If we are in agreement, I may be able to provide a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MWAR-26) Do not overwrite target unless source is
modified
Posted by "John Tolentino (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-26?page=all ]
John Tolentino updated MWAR-26:
-------------------------------
Attachment: MWAR-26-maven-war-plugin-2.diff
> Do not overwrite target unless source is modified
> -------------------------------------------------
>
> Key: MWAR-26
> URL: http://jira.codehaus.org/browse/MWAR-26
> Project: Maven 2.x War Plugin
> Type: Bug
> Reporter: Andres March
> Assignee: John Tolentino
> Fix For: 2.0
> Attachments: MWAR-26-maven-war-plugin-2.diff, MWAR-26-maven-war-plugin.diff
>
> Time Spent: 3 hours, 40 minutes
> Remaining: 0 minutes
>
> I thought MWAR-8 had fixed my issue but it seems to still exist. Correct me if I'm wrong but doing incremental builds with this war plugin is not possible. All the web app sources get overwritten regardless if they have been modified or not. Incremental build were possible in Maven 1 because it was ANT based. This version uses plexus FileUtils which overwrites without regard to if the target file exists or older than the source. Besides the time issue, overwriting the web.xml each time makes my context reload since the context runs on tomcat from the target location. I think this is a reasonable configuration but if there is a better way, let me know. Building inplace wars is not an option as it dirties the source.
> If we are in agreement, I may be able to provide a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MWAR-26) Do not overwrite target unless source is
modified
Posted by "John Tolentino (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-26?page=all ]
John Tolentino updated MWAR-26:
-------------------------------
Attachment: MWAR-26-maven-war-plugin.diff
> Do not overwrite target unless source is modified
> -------------------------------------------------
>
> Key: MWAR-26
> URL: http://jira.codehaus.org/browse/MWAR-26
> Project: Maven 2.x War Plugin
> Type: Bug
> Reporter: Andres March
> Assignee: John Tolentino
> Fix For: 2.0
> Attachments: MWAR-26-maven-war-plugin.diff
>
> Time Spent: 3 hours, 40 minutes
> Remaining: 0 minutes
>
> I thought MWAR-8 had fixed my issue but it seems to still exist. Correct me if I'm wrong but doing incremental builds with this war plugin is not possible. All the web app sources get overwritten regardless if they have been modified or not. Incremental build were possible in Maven 1 because it was ANT based. This version uses plexus FileUtils which overwrites without regard to if the target file exists or older than the source. Besides the time issue, overwriting the web.xml each time makes my context reload since the context runs on tomcat from the target location. I think this is a reasonable configuration but if there is a better way, let me know. Building inplace wars is not an option as it dirties the source.
> If we are in agreement, I may be able to provide a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-26) Do not overwrite target unless source
is modified
Posted by "Andres March (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-26?page=comments#action_61537 ]
Andres March commented on MWAR-26:
----------------------------------
Is it not possible to submit an issue for maven and get them to upgrade to 1.2. If not, will you accept a patch that does not require an upgrade? It may be a bit more code but this is a pretty important feature IMHO.
> Do not overwrite target unless source is modified
> -------------------------------------------------
>
> Key: MWAR-26
> URL: http://jira.codehaus.org/browse/MWAR-26
> Project: Maven 2.x War Plugin
> Type: Bug
> Reporter: Andres March
> Assignee: John Tolentino
> Fix For: 2.0
> Attachments: MWAR-26-maven-war-plugin-2.diff, MWAR-26-maven-war-plugin.diff
>
> Time Spent: 3 hours, 40 minutes
> Remaining: 0 minutes
>
> I thought MWAR-8 had fixed my issue but it seems to still exist. Correct me if I'm wrong but doing incremental builds with this war plugin is not possible. All the web app sources get overwritten regardless if they have been modified or not. Incremental build were possible in Maven 1 because it was ANT based. This version uses plexus FileUtils which overwrites without regard to if the target file exists or older than the source. Besides the time issue, overwriting the web.xml each time makes my context reload since the context runs on tomcat from the target location. I think this is a reasonable configuration but if there is a better way, let me know. Building inplace wars is not an option as it dirties the source.
> If we are in agreement, I may be able to provide a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-26) Do not overwrite target unless source
is modified
Posted by "Edwin Punzalan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-26?page=comments#action_61508 ]
Edwin Punzalan commented on MWAR-26:
------------------------------------
This patch has been reverted in SVN.
> Do not overwrite target unless source is modified
> -------------------------------------------------
>
> Key: MWAR-26
> URL: http://jira.codehaus.org/browse/MWAR-26
> Project: Maven 2.x War Plugin
> Type: Bug
> Reporter: Andres March
> Assignee: John Tolentino
> Fix For: 2.0
> Attachments: MWAR-26-maven-war-plugin-2.diff, MWAR-26-maven-war-plugin.diff
>
> Time Spent: 3 hours, 40 minutes
> Remaining: 0 minutes
>
> I thought MWAR-8 had fixed my issue but it seems to still exist. Correct me if I'm wrong but doing incremental builds with this war plugin is not possible. All the web app sources get overwritten regardless if they have been modified or not. Incremental build were possible in Maven 1 because it was ANT based. This version uses plexus FileUtils which overwrites without regard to if the target file exists or older than the source. Besides the time issue, overwriting the web.xml each time makes my context reload since the context runs on tomcat from the target location. I think this is a reasonable configuration but if there is a better way, let me know. Building inplace wars is not an option as it dirties the source.
> If we are in agreement, I may be able to provide a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MWAR-26) Do not overwrite target unless source is
modified
Posted by "John Tolentino (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-26?page=all ]
John Tolentino updated MWAR-26:
-------------------------------
Attachment: (was: MWAR-26-maven-war-plugin.diff)
> Do not overwrite target unless source is modified
> -------------------------------------------------
>
> Key: MWAR-26
> URL: http://jira.codehaus.org/browse/MWAR-26
> Project: Maven 2.x War Plugin
> Type: Bug
> Reporter: Andres March
> Assignee: John Tolentino
> Fix For: 2.0
> Attachments: MWAR-26-maven-war-plugin.diff
>
> Time Spent: 3 hours, 40 minutes
> Remaining: 0 minutes
>
> I thought MWAR-8 had fixed my issue but it seems to still exist. Correct me if I'm wrong but doing incremental builds with this war plugin is not possible. All the web app sources get overwritten regardless if they have been modified or not. Incremental build were possible in Maven 1 because it was ANT based. This version uses plexus FileUtils which overwrites without regard to if the target file exists or older than the source. Besides the time issue, overwriting the web.xml each time makes my context reload since the context runs on tomcat from the target location. I think this is a reasonable configuration but if there is a better way, let me know. Building inplace wars is not an option as it dirties the source.
> If we are in agreement, I may be able to provide a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MWAR-26) Do not overwrite target unless source is
modified
Posted by "Edwin Punzalan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-26?page=all ]
Edwin Punzalan closed MWAR-26:
------------------------------
Resolution: Fixed
> Do not overwrite target unless source is modified
> -------------------------------------------------
>
> Key: MWAR-26
> URL: http://jira.codehaus.org/browse/MWAR-26
> Project: Maven 2.x War Plugin
> Type: Bug
> Reporter: Andres March
> Assignee: John Tolentino
> Fix For: 2.0
> Attachments: MWAR-26-maven-war-plugin.diff
>
> Time Spent: 8 hours, 40 minutes
> Remaining: 0 minutes
>
> I thought MWAR-8 had fixed my issue but it seems to still exist. Correct me if I'm wrong but doing incremental builds with this war plugin is not possible. All the web app sources get overwritten regardless if they have been modified or not. Incremental build were possible in Maven 1 because it was ANT based. This version uses plexus FileUtils which overwrites without regard to if the target file exists or older than the source. Besides the time issue, overwriting the web.xml each time makes my context reload since the context runs on tomcat from the target location. I think this is a reasonable configuration but if there is a better way, let me know. Building inplace wars is not an option as it dirties the source.
> If we are in agreement, I may be able to provide a patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira