You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "puridach-w (via GitHub)" <gi...@apache.org> on 2023/11/10 08:16:23 UTC

[I] [SIP] Proposal for customize email subject for reports and alerts [superset]

puridach-w opened a new issue, #25945:
URL: https://github.com/apache/superset/issues/25945

   ### Motivation
   
   The primary motivation for this feature comes from our need to send parameters along with the subject of the alert or report email. This feature is designed to make the email subject customizable, enhancing users' ability to make targeted and specific email subject lines.
   
   ### Proposed Change
   
   I propose a feature that allows users to customize the email subject of a report or alert. In the report submission creation interface, I plan to add a text area for entering the email subject. If a user inputs a value in this field, the email's subject will be this value. If not, the system will assign a default email subject line.
   
   Before:
   
   <img width="1171" alt="Screenshot 2566-11-10 at 15 15 52" src="https://github.com/apache/superset/assets/76474644/ec28fb0c-bd8e-4f5d-a577-26df3f7a0e27">
   
   <img width="1173" alt="Screenshot 2566-11-10 at 14 28 09" src="https://github.com/apache/superset/assets/76474644/edb3d66f-2704-48bd-b4ab-21b7a282c8d4">
   
   After: 
   
   <img width="1177" alt="Screenshot 2566-11-10 at 14 08 56" src="https://github.com/apache/superset/assets/76474644/4b2e2329-e9cd-49ad-af79-c384a6f45469">
   
   <img width="1172" alt="Screenshot 2566-11-10 at 14 09 34" src="https://github.com/apache/superset/assets/76474644/1fb4a563-522e-42bb-81a8-eccaaf77755d">
   
   
   ### New or Changed Public Interfaces
   
   I will make a small change to the UI in the 'create alert/report' modal section. If the user selects the email sending method, an additional text area will be available for the user to populate the email subject line.
   
   ### New dependencies
   
   No new packages or libraries will be required to implement this feature.
   
   ### Migration Plan and Compatibility
   
   To incorporate this feature, we will need to initiate a database migration to add columns dedicated to storing email subject lines. We have tested this feature with Superset version 3.0.1 and confirmed that it operates correctly.
   
   ### Rejected Alternatives
   
   None


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] [SIP] Proposal for customize email subject for reports and alerts [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25945:
URL: https://github.com/apache/superset/issues/25945#issuecomment-1808947884

   CC @yousoph and @eschutho on the above. I think we can roll this into the discussion/SIP on the other thread, but I'm also wondering if this change even requires a SIP. If the default remains the same, but this just adds a dimension of customization, it feels harmless. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] [SIP] Proposal for customize email subject for reports and alerts [superset]

Posted by "puridach-w (via GitHub)" <gi...@apache.org>.
puridach-w closed issue #25945: [SIP] Proposal for customize email subject for reports and alerts
URL: https://github.com/apache/superset/issues/25945


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] [SIP] Proposal for customize email subject for reports and alerts [superset]

Posted by "puridach-w (via GitHub)" <gi...@apache.org>.
puridach-w commented on issue #25945:
URL: https://github.com/apache/superset/issues/25945#issuecomment-1809564502

   Move the discussion to following SIP: https://github.com/apache/superset/discussions/25729


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] [SIP] Proposal for customize email subject for reports and alerts [superset]

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #25945:
URL: https://github.com/apache/superset/issues/25945#issuecomment-1806160933

   Hi @puridach-w. Thanks for the proposal. I think it would be a good idea to incorporate your changes into this [discussion](https://github.com/apache/superset/discussions/25729) which will become a SIP in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] [SIP] Proposal for customize email subject for reports and alerts [superset]

Posted by "puridach-w (via GitHub)" <gi...@apache.org>.
puridach-w closed issue #25945: [SIP] Proposal for customize email subject for reports and alerts
URL: https://github.com/apache/superset/issues/25945


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] [SIP] Proposal for customize email subject for reports and alerts [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25945:
URL: https://github.com/apache/superset/issues/25945#issuecomment-2159186439

   It seems this SIP was never numbered or put up for a [DISCUSS] thread. Is there still intent to follow through the process with this one? Are you interested in opening the PR if we do usher it through, @puridach-w ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] [SIP] Proposal for customize email subject for reports and alerts [superset]

Posted by "puridach-w (via GitHub)" <gi...@apache.org>.
puridach-w commented on issue #25945:
URL: https://github.com/apache/superset/issues/25945#issuecomment-2159476878

   This PR relate to this SIP has been completed. I will now close it. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org