You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/08/02 10:47:35 UTC
[GitHub] [hive] abstractdog opened a new pull request, #3491: HIVE-26444: Use tez.local.mode.without.network for unit tests
abstractdog opened a new pull request, #3491:
URL: https://github.com/apache/hive/pull/3491
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] abstractdog merged pull request #3491: HIVE-26444: Use tez.local.mode.without.network for unit tests
Posted by GitBox <gi...@apache.org>.
abstractdog merged PR #3491:
URL: https://github.com/apache/hive/pull/3491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on a diff in pull request #3491: HIVE-26444: Use tez.local.mode.without.network for unit tests
Posted by GitBox <gi...@apache.org>.
zabetak commented on code in PR #3491:
URL: https://github.com/apache/hive/pull/3491#discussion_r936432254
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveShell.java:
##########
@@ -201,6 +201,8 @@ private HiveConf initializeConf() {
// Tez configuration
hiveConf.setBoolean("tez.local.mode", true);
+ // TODO: enable below option once HIVE-26445 is investigated
+ // hiveConf.setBoolean("tez.local.mode.without.network", true);
Review Comment:
Sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on a diff in pull request #3491: HIVE-26444: Use tez.local.mode.without.network for unit tests
Posted by GitBox <gi...@apache.org>.
zabetak commented on code in PR #3491:
URL: https://github.com/apache/hive/pull/3491#discussion_r935774590
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveShell.java:
##########
@@ -201,6 +201,8 @@ private HiveConf initializeConf() {
// Tez configuration
hiveConf.setBoolean("tez.local.mode", true);
+ // TODO: enable below option once HIVE-26445 is investigated
+ // hiveConf.setBoolean("tez.local.mode.without.network", true);
Review Comment:
If there are failures due to the change then it becomes a bit doubtful if setting the property always to true is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ayushtkn commented on a diff in pull request #3491: HIVE-26444: Use tez.local.mode.without.network for unit tests
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on code in PR #3491:
URL: https://github.com/apache/hive/pull/3491#discussion_r936247615
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveShell.java:
##########
@@ -201,6 +201,8 @@ private HiveConf initializeConf() {
// Tez configuration
hiveConf.setBoolean("tez.local.mode", true);
+ // TODO: enable below option once HIVE-26445 is investigated
+ // hiveConf.setBoolean("tez.local.mode.without.network", true);
Review Comment:
Not sure but it says in the description:
```
which is in the same JVM as the client.
```
May be some instance is getting shared by the client and one change is impacting other, hence the NPE which is mentioned in HIVE-26445.
I share the same doubt as @zabetak , we should atleast figure out the reason for failure if it is nothing core-related this property, then this should be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] abstractdog commented on a diff in pull request #3491: HIVE-26444: Use tez.local.mode.without.network for unit tests
Posted by GitBox <gi...@apache.org>.
abstractdog commented on code in PR #3491:
URL: https://github.com/apache/hive/pull/3491#discussion_r936304092
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveShell.java:
##########
@@ -201,6 +201,8 @@ private HiveConf initializeConf() {
// Tez configuration
hiveConf.setBoolean("tez.local.mode", true);
+ // TODO: enable below option once HIVE-26445 is investigated
+ // hiveConf.setBoolean("tez.local.mode.without.network", true);
Review Comment:
recently, only hive iceberg related tests failed [here](http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-3491/2/pipeline), and I cannot easily disable this feature only for TestIcebergLlapLocalCliDriver (but not for other CliDrivers), so I'm about to make this change only for some unit tests (which I targeted originally), and handle all the qtests in the followup HIVE-26445, does it make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org