You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "bodhili (via GitHub)" <gi...@apache.org> on 2023/06/03 03:37:02 UTC

[GitHub] [dubbo-go] bodhili commented on a diff in pull request #2320: feat: print logs of registered providers and consumers

bodhili commented on code in PR #2320:
URL: https://github.com/apache/dubbo-go/pull/2320#discussion_r1215167602


##########
config/provider_config.go:
##########
@@ -75,14 +76,28 @@ func (c *ProviderConfig) Init(rc *RootConfig) error {
 	if c == nil {
 		return nil
 	}
+	logger.Debug("test")
+	buildDebugMsg := func() string {

Review Comment:
   buildDebugMsg := func() string {
   		if len(c.Services) != 0 {
   			providerNames := make([]string, 0, len(c.Services))
   			for k := range c.Services {
   				providerNames = append(providerNames, k)
   			}
   			return strings.Join(providerNames, ", ")
   		} 
   		return "empty"
   	}



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org