[GitHub] [hive] dengzhhu653 commented on a diff in pull request #4164: HIVE-27179: HS2 WebUI throws NPE when JspFactory loaded from jetty-runner

["dengzhhu653 (via GitHub)" <gi...@apache.org>]

dengzhhu653 commented on code in PR #4164:
URL: https://github.com/apache/hive/pull/4164#discussion_r1152729260


##########
service/src/java/org/apache/hive/service/server/HiveServer2.java:
##########
@@ -133,6 +133,8 @@
 import com.google.common.util.concurrent.SettableFuture;
 import com.google.common.util.concurrent.ThreadFactoryBuilder;
 
+import javax.servlet.jsp.JspFactory;

Review Comment:
   Hi @saihemanth-cloudera, the jetty-runner jar contains the classes:
   ```
   [Loaded javax.servlet.jsp.JspFactory from file:/opt/xxx/jetty-runner-9.4.48.v20220622.jar]
   [Loaded javax.servlet.jsp.JspContext from file:/opt/xxx/jetty-runner-9.4.48.v20220622.jar]
   [Loaded javax.servlet.jsp.PageContext from file:/opt/xxx/jetty-runner-9.4.48.v20220622.jar]
   ```
   In fact this is where the class conflict happens.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org