You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by d2r <gi...@git.apache.org> on 2015/03/30 18:06:10 UTC

[GitHub] storm pull request: STORM-593: remove endpoint-socket-lock for wor...

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/349#discussion_r27404105
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/worker.clj ---
    @@ -302,9 +301,8 @@
                                port)
                               ]
                              )))
    -              (write-locked (:endpoint-socket-lock worker)
    -                (reset! (:cached-task->node+port worker)
    -                        (HashMap. my-assignment)))
    --- End diff --
    
    The only other place `:cached-task->node+port` is used, it is only a read in `mk-transfer-fn`.  Since it is already an atom, we probably do not need this lock.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---