You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/30 00:58:58 UTC

[GitHub] [iceberg] stevenzwu commented on pull request #2886: Flink: if provided, add uidPrefix to operator name so that Flink web …

stevenzwu commented on pull request #2886:
URL: https://github.com/apache/iceberg/pull/2886#issuecomment-889553074


   @openinx I addressed your comments in the last commit. it is a good call to add a unit test. Through the unit test, I also found that uid wasn't set the map operator. Latest commit addressed it. Because I don't want to change the `Builder` class to a generic type. I added a `mappedRowDataInput` variable to distinguish this case so that we can add the uid and name in the `build()` method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org