You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2023/01/11 14:05:09 UTC
[GitHub] [lucene] benwtrent opened a new pull request, #12075: Create new KnnByteVectorField and KnnVectorsReader#getByteVectorValues(String) (#12064)
benwtrent opened a new pull request, #12075:
URL: https://github.com/apache/lucene/pull/12075
Backport of #12064
This completes the refactoring as described in: https://github.com/apache/lucene/issues/11963
This commit:
- splits out `ByteVectorValues` from `VectorValues`.
- Adds `getByteVectorValues(String field)` to `KnnVectorsReader`
- Adds a new `KnnByteVectorField` and disallows `BytesRef` values in the `KnnVectorField`
- No longer allows `ByteVectorValues` to be read from a `KnnVectorField`.
These refactors are difficult to split up any further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz merged pull request #12075: Create new KnnByteVectorField and KnnVectorsReader#getByteVectorValues(String) (#12064)
Posted by GitBox <gi...@apache.org>.
jpountz merged PR #12075:
URL: https://github.com/apache/lucene/pull/12075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] benwtrent commented on pull request #12075: Create new KnnByteVectorField and KnnVectorsReader#getByteVectorValues(String) (#12064)
Posted by GitBox <gi...@apache.org>.
benwtrent commented on PR #12075:
URL: https://github.com/apache/lucene/pull/12075#issuecomment-1378802761
@jpountz backport :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #12075: Create new KnnByteVectorField and KnnVectorsReader#getByteVectorValues(String) (#12064)
Posted by GitBox <gi...@apache.org>.
jpountz commented on PR #12075:
URL: https://github.com/apache/lucene/pull/12075#issuecomment-1378896877
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org