You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Stanton Sievers <si...@gmail.com> on 2013/03/06 21:43:18 UTC
Re: Review Request: Allow EhCache DiskStore location to be easily
configurable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9763/
-----------------------------------------------------------
(Updated March 6, 2013, 8:43 p.m.)
Review request for shindig and Dan Dumont.
Changes
-------
Adding the dev list
Description
-------
I'd like to make the location of EhCache's disk stores easily configurable via the web.xml of an app, instead of having to inject one's own EhCacheCacheProvider.
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java 1453022
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml 1453022
Diff: https://reviews.apache.org/r/9763/diff/
Testing
-------
I set "ehcache.disk.store.dir" to "C:\tmp\.ehcache" in my web.xml and verified that EhCache started creating disk stores in that directory. I also verified that if I did not set "ehcache.disk.store.dir" then the disk stores were created in my system's temp directory, as defined by "java.io.tmpdir".
Thanks,
Stanton Sievers
Re: Review Request: Allow EhCache DiskStore location to be easily
configurable
Posted by Stanton Sievers <si...@gmail.com>.
> On March 6, 2013, 9:21 p.m., Ryan Baxter wrote:
> > LGTM. I assume the provider will run before the ehcache config file is read?
>
> Ryan Baxter wrote:
> Would be great to have a JIRA for this as well. I know the change is small but its adding more configuration flexibility and it would be nice to include in release notes.
Yes, the provider is what reads in the ehCacheConfig.xml file. See org.apache.shindig.common.cache.ehcache.EhCacheCacheProvider.getConfiguration(String)
- Stanton
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9763/#review17491
-----------------------------------------------------------
On March 7, 2013, 1:31 a.m., Stanton Sievers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9763/
> -----------------------------------------------------------
>
> (Updated March 7, 2013, 1:31 a.m.)
>
>
> Review request for shindig and Dan Dumont.
>
>
> Description
> -------
>
> I'd like to make the location of EhCache's disk stores easily configurable via the web.xml of an app, instead of having to inject one's own EhCacheCacheProvider.
>
>
> This addresses bug SHINDIG-1912.
> https://issues.apache.org/jira/browse/SHINDIG-1912
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java 1453022
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml 1453022
>
> Diff: https://reviews.apache.org/r/9763/diff/
>
>
> Testing
> -------
>
> I set "ehcache.disk.store.dir" to "C:\tmp\.ehcache" in my web.xml and verified that EhCache started creating disk stores in that directory. I also verified that if I did not set "ehcache.disk.store.dir" then the disk stores were created in my system's temp directory, as defined by "java.io.tmpdir".
>
>
> Thanks,
>
> Stanton Sievers
>
>
Re: Review Request: Allow EhCache DiskStore location to be easily
configurable
Posted by Ryan Baxter <rb...@gmail.com>.
> On March 6, 2013, 9:21 p.m., Ryan Baxter wrote:
> > LGTM. I assume the provider will run before the ehcache config file is read?
Would be great to have a JIRA for this as well. I know the change is small but its adding more configuration flexibility and it would be nice to include in release notes.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9763/#review17491
-----------------------------------------------------------
On March 6, 2013, 8:43 p.m., Stanton Sievers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9763/
> -----------------------------------------------------------
>
> (Updated March 6, 2013, 8:43 p.m.)
>
>
> Review request for shindig and Dan Dumont.
>
>
> Description
> -------
>
> I'd like to make the location of EhCache's disk stores easily configurable via the web.xml of an app, instead of having to inject one's own EhCacheCacheProvider.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java 1453022
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml 1453022
>
> Diff: https://reviews.apache.org/r/9763/diff/
>
>
> Testing
> -------
>
> I set "ehcache.disk.store.dir" to "C:\tmp\.ehcache" in my web.xml and verified that EhCache started creating disk stores in that directory. I also verified that if I did not set "ehcache.disk.store.dir" then the disk stores were created in my system's temp directory, as defined by "java.io.tmpdir".
>
>
> Thanks,
>
> Stanton Sievers
>
>
Re: Review Request: Allow EhCache DiskStore location to be easily
configurable
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9763/#review17491
-----------------------------------------------------------
Ship it!
LGTM. I assume the provider will run before the ehcache config file is read?
- Ryan Baxter
On March 6, 2013, 8:43 p.m., Stanton Sievers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9763/
> -----------------------------------------------------------
>
> (Updated March 6, 2013, 8:43 p.m.)
>
>
> Review request for shindig and Dan Dumont.
>
>
> Description
> -------
>
> I'd like to make the location of EhCache's disk stores easily configurable via the web.xml of an app, instead of having to inject one's own EhCacheCacheProvider.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java 1453022
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml 1453022
>
> Diff: https://reviews.apache.org/r/9763/diff/
>
>
> Testing
> -------
>
> I set "ehcache.disk.store.dir" to "C:\tmp\.ehcache" in my web.xml and verified that EhCache started creating disk stores in that directory. I also verified that if I did not set "ehcache.disk.store.dir" then the disk stores were created in my system's temp directory, as defined by "java.io.tmpdir".
>
>
> Thanks,
>
> Stanton Sievers
>
>
Re: Review Request: Allow EhCache DiskStore location to be easily
configurable
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9763/#review17701
-----------------------------------------------------------
Ship it!
Comitted Revision 1455358
- Stanton Sievers
On March 11, 2013, 11:01 p.m., Stanton Sievers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9763/
> -----------------------------------------------------------
>
> (Updated March 11, 2013, 11:01 p.m.)
>
>
> Review request for shindig and Dan Dumont.
>
>
> Description
> -------
>
> I'd like to make the location of EhCache's disk stores easily configurable via the web.xml of an app, instead of having to inject one's own EhCacheCacheProvider.
>
>
> This addresses bug SHINDIG-1912.
> https://issues.apache.org/jira/browse/SHINDIG-1912
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java 1454767
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml 1454767
>
> Diff: https://reviews.apache.org/r/9763/diff/
>
>
> Testing
> -------
>
> I set "ehcache.disk.store.dir" to "C:\tmp\.ehcache" in my web.xml and verified that EhCache started creating disk stores in that directory. I also verified that if I did not set "ehcache.disk.store.dir" then the disk stores were created in my system's temp directory, as defined by "java.io.tmpdir".
>
>
> Thanks,
>
> Stanton Sievers
>
>
Re: Review Request: Allow EhCache DiskStore location to be easily
configurable
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9763/
-----------------------------------------------------------
(Updated March 11, 2013, 11:01 p.m.)
Review request for shindig and Dan Dumont.
Changes
-------
Updating the patch so that this review accurately reflects what I committed.
Description
-------
I'd like to make the location of EhCache's disk stores easily configurable via the web.xml of an app, instead of having to inject one's own EhCacheCacheProvider.
This addresses bug SHINDIG-1912.
https://issues.apache.org/jira/browse/SHINDIG-1912
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java 1454767
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml 1454767
Diff: https://reviews.apache.org/r/9763/diff/
Testing
-------
I set "ehcache.disk.store.dir" to "C:\tmp\.ehcache" in my web.xml and verified that EhCache started creating disk stores in that directory. I also verified that if I did not set "ehcache.disk.store.dir" then the disk stores were created in my system's temp directory, as defined by "java.io.tmpdir".
Thanks,
Stanton Sievers
Re: Review Request: Allow EhCache DiskStore location to be easily
configurable
Posted by Marshall Shi <sh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9763/#review17508
-----------------------------------------------------------
Ship it!
Nice improvement, LGTM!
- Marshall Shi
On March 7, 2013, 1:31 a.m., Stanton Sievers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9763/
> -----------------------------------------------------------
>
> (Updated March 7, 2013, 1:31 a.m.)
>
>
> Review request for shindig and Dan Dumont.
>
>
> Description
> -------
>
> I'd like to make the location of EhCache's disk stores easily configurable via the web.xml of an app, instead of having to inject one's own EhCacheCacheProvider.
>
>
> This addresses bug SHINDIG-1912.
> https://issues.apache.org/jira/browse/SHINDIG-1912
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java 1453022
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml 1453022
>
> Diff: https://reviews.apache.org/r/9763/diff/
>
>
> Testing
> -------
>
> I set "ehcache.disk.store.dir" to "C:\tmp\.ehcache" in my web.xml and verified that EhCache started creating disk stores in that directory. I also verified that if I did not set "ehcache.disk.store.dir" then the disk stores were created in my system's temp directory, as defined by "java.io.tmpdir".
>
>
> Thanks,
>
> Stanton Sievers
>
>
Re: Review Request: Allow EhCache DiskStore location to be easily
configurable
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9763/
-----------------------------------------------------------
(Updated March 7, 2013, 1:31 a.m.)
Review request for shindig and Dan Dumont.
Changes
-------
Adding a JIRA.
Description
-------
I'd like to make the location of EhCache's disk stores easily configurable via the web.xml of an app, instead of having to inject one's own EhCacheCacheProvider.
This addresses bug SHINDIG-1912.
https://issues.apache.org/jira/browse/SHINDIG-1912
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java 1453022
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml 1453022
Diff: https://reviews.apache.org/r/9763/diff/
Testing
-------
I set "ehcache.disk.store.dir" to "C:\tmp\.ehcache" in my web.xml and verified that EhCache started creating disk stores in that directory. I also verified that if I did not set "ehcache.disk.store.dir" then the disk stores were created in my system's temp directory, as defined by "java.io.tmpdir".
Thanks,
Stanton Sievers