You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by wr...@apache.org on 2003/03/06 09:43:40 UTC

cvs commit: httpd-2.0/modules/ssl ssl_engine_init.c

wrowe       2003/03/06 00:43:40

  Modified:    modules/ssl ssl_engine_init.c
  Log:
    DougM confirms Madhu's suspicions, this change was inadvertent.
    Reverting to no longer skip the first cert in the chain.
  
  Revision  Changes    Path
  1.111     +1 -1      httpd-2.0/modules/ssl/ssl_engine_init.c
  
  Index: ssl_engine_init.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/ssl/ssl_engine_init.c,v
  retrieving revision 1.110
  retrieving revision 1.111
  diff -u -r1.110 -r1.111
  --- ssl_engine_init.c	3 Feb 2003 17:53:11 -0000	1.110
  +++ ssl_engine_init.c	6 Mar 2003 08:43:39 -0000	1.111
  @@ -656,7 +656,7 @@
                                       apr_pool_t *ptemp,
                                       modssl_ctx_t *mctx)
   {
  -    BOOL skip_first = TRUE;
  +    BOOL skip_first = FALSE;
       int i, n;
       const char *chain = mctx->cert_chain;
   
  
  
  

Re: cvs commit: httpd-2.0/modules/ssl ssl_engine_init.c

Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Good to see that at least one more individual recognized the problem!
Unfortunately with bugzilla, I have only an email addy, and don't see
a name.  In any case, Madhu's patch hit first, so that's the name I went
with.

Bill

At 09:10 AM 3/6/2003, Jeff Trawick wrote:
>http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14560
>
>William A. Rowe, Jr. wrote:
>
>>At 06:12 AM 3/6/2003, Jeff Trawick wrote:
>>
>>>wrowe@apache.org wrote:
>>>
>>>
>>>>wrowe       2003/03/06 00:43:40
>>>>
>>>> Modified:    modules/ssl ssl_engine_init.c
>>>> Log:
>>>>   DougM confirms Madhu's suspicions, this change was inadvertent.
>>>>   Reverting to no longer skip the first cert in the chain.
>>>
>>>Don't forget CHANGES and the PR number.  ISTR that somebody submitted this patch already.
>
>



Re: cvs commit: httpd-2.0/modules/ssl ssl_engine_init.c

Posted by Jeff Trawick <tr...@attglobal.net>.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14560

William A. Rowe, Jr. wrote:

> At 06:12 AM 3/6/2003, Jeff Trawick wrote:
>
> >wrowe@apache.org wrote:
> >
> >
> >>wrowe       2003/03/06 00:43:40
> >>
> >> Modified:    modules/ssl ssl_engine_init.c
> >> Log:
> >>   DougM confirms Madhu's suspicions, this change was inadvertent.
> >>   Reverting to no longer skip the first cert in the chain.
> >
> >Don't forget CHANGES and the PR number.  ISTR that somebody submitted 
> this patch already.



Re: cvs commit: httpd-2.0/modules/ssl ssl_engine_init.c

Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At 06:12 AM 3/6/2003, Jeff Trawick wrote:
>wrowe@apache.org wrote:
>
>>wrowe       2003/03/06 00:43:40
>>
>>  Modified:    modules/ssl ssl_engine_init.c
>>  Log:
>>    DougM confirms Madhu's suspicions, this change was inadvertent.
>>    Reverting to no longer skip the first cert in the chain.
>
>Don't forget CHANGES and the PR number.  ISTR that somebody submitted this patch already.

Madhu pointed it out on list... if it was in Bugzilla, I missed it, but I'll
go looking now :-(

Bill



Re: cvs commit: httpd-2.0/modules/ssl ssl_engine_init.c

Posted by Jeff Trawick <tr...@attglobal.net>.
wrowe@apache.org wrote:

> wrowe       2003/03/06 00:43:40
>
>   Modified:    modules/ssl ssl_engine_init.c
>   Log:
>     DougM confirms Madhu's suspicions, this change was inadvertent.
>     Reverting to no longer skip the first cert in the chain.

Don't forget CHANGES and the PR number.  ISTR that somebody submitted 
this patch already.