You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by Apache Wiki <wi...@apache.org> on 2013/06/20 07:06:35 UTC

[Jclouds Wiki] Update of "Committers Guide" by mattstep

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Jclouds Wiki" for change notification.

The "Committers Guide" page has been changed by mattstep:
https://wiki.apache.org/jclouds/Committers%20Guide

New page:
== The Git repositories ==

The jclouds Git repositories are hosted in the ASF infrastructure, but there are also have mirros in Github. This is the current repository layout:

|| Apache || https://git-wip-us.apache.org/repos/asf?s=incubator-jclouds || The main and official repositories ||
|| Github || https://github.com/jclouds/jclouds || Mirrors from the ASF repositories, used to accept contributions and do code reviews ||
|| Github || https://github.com/jclouds/legacy-jclouds || The legacy repositories, as they were before the migration to the ASF, used to keep old code ||

== Rules of thumb ==
 1. Every contribution is a piece of intellectual property.  This is the precious sustenance that nourishes our project.  Please treat it with respect.  If it's sufficiently complex, or from a large corporate entity, ensure there is an ICLA or CCLA on file that covers the contribution.  Asking in #jclouds or #asf will probably be the easiest way to get an answer.
 2. ALWAYS give credit where it is due, ensure EVERY merged commit reflects properly the individual who authored that commit.  Preserve both the name and email address.
 3. Ensure your name and email address are there as the committer prior to pushing it to the Apache repositories.
 4. Always strive for linear commit history, avoid merge commits while pulling in contributor's changes.

== Commiting the changes to the ASF repo ==

 1. Save the patch from the Github patch link (just appehd '.patch' to the pull request link to get it). This patch will keep the authorship of the commit, so we should use it instead of the diff.
 2. If the commit message needs to be edited, edit it in the patch file.
 3. Pull the changes in the ASF repository to make sure you have the latest version of the master branch.
  {{{
  git remote add asf https://git-wip-us.apache.org/repos/asf/incubator-jclouds.git
  git fetch asf
  git checkout master
  git rebase asf/master
  }}}
 4. Apply the patch preserving the original author:
  {{{
  git am JCLOUDS-XX.patch
  }}}
 5. Run a build to make sure everything works as expected after applying the patch and push the changes once the build succeeds.
  {{{
  mvn clean install
  git push asf master
  }}}
 6. If there are no issues with the applied patch, attach the patch file to the JIRA issue, and mark it as Resolved.
 7. Close the pull request and leave a comment saying it has been merged.