[GitHub] raphinesse commented on a change in pull request #194: Remove lazy eslint flags

[GitBox <gi...@apache.org>]

raphinesse commented on a change in pull request #194: Remove lazy eslint flags
URL: https://github.com/apache/cordova-coho/pull/194#discussion_r213610481
 
 

 ##########
 File path: src/shortlog.js
 ##########
 @@ -40,8 +40,7 @@ module.exports = function * () {
     var repos = flagutil.computeReposFromFlag(argv.r);
     var emailFilter = argv.filter && new RegExp(argv.filter);
     var days = argv.days || 7;
-    /* eslint-enable no-undef */
-    var resultsByAuthor = Object.create(null);
+    var resultsByAuthor = {};
 
 Review comment:
   Actually, [`Object.create(null)` is safer](https://davidwalsh.name/object-create-null), so I'd keep it. Not that I would ever bother to do that in my code, but if it's already there :man_shrugging:

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org