You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/01 14:30:00 UTC
[GitHub] [airflow] RagingPuppies opened a new pull request, #28034: Added custom environment variables to statsd
RagingPuppies opened a new pull request, #28034:
URL: https://github.com/apache/airflow/pull/28034
Hi,
This is not related to any issue, all airflow components have the option to add custom env to their docker container except statsd, I've just added the same functionality and tested the chart in debug mode. (as I don't think the unit tests have any relation to the helm charts.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RagingPuppies commented on a diff in pull request #28034: Added custom environment variables to statsd
Posted by GitBox <gi...@apache.org>.
RagingPuppies commented on code in PR #28034:
URL: https://github.com/apache/airflow/pull/28034#discussion_r1038930430
##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -115,6 +115,10 @@ spec:
- name: config
mountPath: /etc/statsd-exporter/mappings.yml
subPath: mappings.yml
+{{- if .Values.statsd.env}}
+ env:
+ {{- include "container_extra_envs" (list . .Values.statsd.env) | indent 10 }}
Review Comment:
@jedcunningham as Flower is not an airflow container as well, but it did use the same code, don't you think it should be aligned?
https://github.com/apache/airflow/blob/8f98bfeb5372c7f61c77f081afb9b277c35b88ed/chart/templates/flower/flower-deployment.yaml#L142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28034: Added custom environment variables to statsd
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28034:
URL: https://github.com/apache/airflow/pull/28034#issuecomment-1356864111
Are you still working on it @RagingPuppies ? If so - it needs rebase/conflict resolving
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #28034: Added custom environment variables to statsd
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #28034: Added custom environment variables to statsd
URL: https://github.com/apache/airflow/pull/28034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #28034: Added custom environment variables to statsd
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28034:
URL: https://github.com/apache/airflow/pull/28034#issuecomment-1454289497
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28034: Added custom environment variables to statsd
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #28034:
URL: https://github.com/apache/airflow/pull/28034#issuecomment-1333852450
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #28034: Added custom environment variables to statsd
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #28034:
URL: https://github.com/apache/airflow/pull/28034#discussion_r1037668526
##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -115,6 +115,10 @@ spec:
- name: config
mountPath: /etc/statsd-exporter/mappings.yml
subPath: mappings.yml
+{{- if .Values.statsd.env}}
+ env:
+ {{- include "container_extra_envs" (list . .Values.statsd.env) | indent 10 }}
Review Comment:
Since this isn't an Airflow container, we don't need to use this helper here.
##########
chart/values.schema.json:
##########
@@ -4023,6 +4023,27 @@
"default": null,
"x-docsSection": null
},
+ "env": {
+ "description": "Add additional env vars to stats.",
+ "type": "array",
+ "default": [],
+ "items": {
+ "type": "object",
+ "properties": {
+ "name": {
+ "type": "string"
+ },
+ "value": {
+ "type": "string"
+ }
+ },
+ "required": [
+ "name",
+ "value"
+ ],
+ "additionalProperties": false
Review Comment:
```suggestion
"$ref": "#/definitions/io.k8s.api.core.v1.EnvVar"
```
And we can allow "normal" env vars here because of that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RagingPuppies commented on pull request #28034: Added custom environment variables to statsd
Posted by GitBox <gi...@apache.org>.
RagingPuppies commented on PR #28034:
URL: https://github.com/apache/airflow/pull/28034#issuecomment-1367261828
yes, @potiuk didn't have the time, pushed a new commit to fix @jedcunningham rejects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28034: Added custom environment variables to statsd
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28034:
URL: https://github.com/apache/airflow/pull/28034#issuecomment-1385027099
Some conflicts still need to be solved @RagingPuppies now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #28034: Added custom environment variables to statsd
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #28034:
URL: https://github.com/apache/airflow/pull/28034#discussion_r1054698659
##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -115,6 +115,10 @@ spec:
- name: config
mountPath: /etc/statsd-exporter/mappings.yml
subPath: mappings.yml
+{{- if .Values.statsd.env}}
+ env:
+ {{- include "container_extra_envs" (list . .Values.statsd.env) | indent 10 }}
Review Comment:
The difference is flower is started via the Airflow cli, and this run in a completely separate image that doesn't even have Airflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org