You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2020/02/06 12:07:02 UTC

[GitHub] [fluo-muchos] billierinaldi opened a new pull request #321: Add stat 4lw for zookeeper

billierinaldi opened a new pull request #321: Add stat 4lw for zookeeper
URL: https://github.com/apache/fluo-muchos/pull/321
 
 
   @arvindshmicrosoft observed that the stat four letter word is used by the Accumulo monitor. Also, the 4lw.commands.whitelist property for ZooKeeper has been backported to 3.4.10 with a more permissive default (see https://issues.apache.org/jira/browse/ZOOKEEPER-2693), so we were inadvertently disabling a lot of four letter words that are enabled by default in 3.4. In 3.5, the AdminServer provides an alternative for retrieving the same information, so the four letter words can be disabled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] billierinaldi merged pull request #321: Add stat 4lw for zookeeper

Posted by GitBox <gi...@apache.org>.
billierinaldi merged pull request #321: Add stat 4lw for zookeeper
URL: https://github.com/apache/fluo-muchos/pull/321
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] arvindshmicrosoft commented on a change in pull request #321: Add stat 4lw for zookeeper

Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on a change in pull request #321: Add stat 4lw for zookeeper
URL: https://github.com/apache/fluo-muchos/pull/321#discussion_r376058384
 
 

 ##########
 File path: ansible/roles/zookeeper/templates/zoo.cfg
 ##########
 @@ -16,7 +16,9 @@ clientPort={{ zookeeper_client_port }}
 # increase this if you need to handle more clients
 maxClientCnxns=100
 # support zk monitoring (for zk >= 3.5)
-4lw.commands.whitelist=mntr
+{% if zookeeper_version.startswith('3.5') %}
 
 Review comment:
   There seems to be a [better way](https://docs.ansible.com/ansible/latest/user_guide/playbooks_tests.html#version-comparison) in Ansible to compare versions. Specifically we can use the below instead of the string approach:
   
   ```zookeeper_version is version('3.5', '>=')```
   
   I did a quick unit test with the below playbook and it works as intended, including minor version handling.
   ```
   - hosts: localhost
     gather_facts: no
     tasks:
             - set_fact:
                     zookeeper_version: "3.5.6"
             - debug:
                     msg: "needs whitelist"
               when: zookeeper_version is version('3.5', '>=')
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] arvindshmicrosoft commented on a change in pull request #321: Add stat 4lw for zookeeper

Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on a change in pull request #321: Add stat 4lw for zookeeper
URL: https://github.com/apache/fluo-muchos/pull/321#discussion_r376058384
 
 

 ##########
 File path: ansible/roles/zookeeper/templates/zoo.cfg
 ##########
 @@ -16,7 +16,9 @@ clientPort={{ zookeeper_client_port }}
 # increase this if you need to handle more clients
 maxClientCnxns=100
 # support zk monitoring (for zk >= 3.5)
-4lw.commands.whitelist=mntr
+{% if zookeeper_version.startswith('3.5') %}
 
 Review comment:
   There seems to be a better way in Ansible to compare versions. Specifically we can use the below instead of the string approach:
   
   ```zookeeper_version is version('3.5', '>=')```
   
   I did a quick unit test with the below playbook and it works as intended, including minor version handling.
   ```
   - hosts: localhost
     gather_facts: no
     tasks:
             - set_fact:
                     zookeeper_version: "3.5.6"
             - debug:
                     msg: "needs whitelist"
               when: zookeeper_version is version('3.5', '>=')
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services