You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by scop <gi...@git.apache.org> on 2016/06/13 21:23:31 UTC
[GitHub] activemq-artemis pull request #579: Remove redundant type arguments, add sev...
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/579
Remove redundant type arguments, add sevntu-checkstyle check for it
Hopefully with this check I don't need to keep submitting the redundant type args PR's any more :)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis redundant2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/579.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #579
----
commit 04fefcc851f153f648f2e13a58b65df4a94a87b9
Author: Ville Skytt� <vi...@iki.fi>
Date: 2016-06-13T21:18:58Z
Add Sevntu-checkstyle diamond operator check
commit 051bb174e40aba5d4c5b7539fc36afbf334691f7
Author: Ville Skytt� <vi...@iki.fi>
Date: 2016-06-13T21:20:31Z
Remove redundant type arguments
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #579: Remove redundant type arguments, add sevntu-che...
Posted by scop <gi...@git.apache.org>.
Github user scop commented on the issue:
https://github.com/apache/activemq-artemis/pull/579
The last commit is unrelated to the diamond operator, but depends on the sevntu addition so I thought I'd just bundle it here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #579: Remove redundant type arguments, add sev...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/579
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #579: Remove redundant type arguments, add sevntu-che...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/579
@scop Here is my PR: https://github.com/sevntu-checkstyle/sevntu.checkstyle/pull/203
it was replaced by another pr:
https://github.com/sevntu-checkstyle/sevntu.checkstyle/issues/321
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #579: Remove redundant type arguments, add sevntu-che...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/579
Oh.. wow.. you already did it.. awesome!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #579: Remove redundant type arguments, add sevntu-che...
Posted by bwzhang2011 <gi...@git.apache.org>.
Github user bwzhang2011 commented on the issue:
https://github.com/apache/activemq-artemis/pull/579
@clebertsuconic, sevntu checkstyle plugin address was wrong that we could not simply build it right for I could not access the url http://sevntu-checkstyle.github.io/sevntu.checkstyle/maven2. and it's better that the dependency for maven-checkstyle-plugin should be dsm-maven-plugin. so if it was replaced by as follows:
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.17</version>
<dependencies>
<dependency>
<groupId>com.github.sevntu-checkstyle</groupId>
<artifactId>dsm-maven-plugin</artifactId>
<version>2.1.4</version>
</dependency>
</dependencies>
and comment out the sevntu url . the 1.4 release could be built as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #579: Remove redundant type arguments, add sevntu-che...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/579
Can you send a PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #579: Remove redundant type arguments, add sevntu-che...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/579
@scop Since you are adding Seventu, can I ask you a favour?
I had this on the checkstyle: org.hornetq.checks.annotation.RequiredAnnotation,
Which I started as a PR on Seventu. I have written a PR for them, but I couldn't finish it because they had too many requirements, and I didn't have time to finish, so I think someone took over my contribution and finished into Seventu.
Can you check on replacing my RequiredAnnotations by the one on Seventu, which I believe my contribution has made into there? if you can't just let me know and I will find some time to do it later this week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---