[jira] Closed: (SHINDIG-81) core dependencies not always added to features in the GadgetFeatureRegistry.registerFeatures function?

["Kevin Brown (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHINDIG-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Brown closed SHINDIG-81.
------------------------------

    Resolution: Fixed

> core dependencies not always added to features in the GadgetFeatureRegistry.registerFeatures function?
> ------------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-81
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-81
>             Project: Shindig
>          Issue Type: Bug
>            Reporter: Chris Chabot
>            Assignee: Brian McCallister
>
> In theGadgetFeatureRegistry.registerFeatures function there is  a boolean value coreDone, which, i presume, allows the registerFeatures function to be called multiple times without parsing the core modules every time. And at the end of the (!coreDone) statement, it adds the core features as dependencies to all the loaded features.
> However if you were to call this function a second time, the core dependencies wouldn't be added to the new features added since coreDone is set to true already .... so either it wouldn't need a coreDone check since it would only be called once, or its a bug that if you would call it a second time, the core dependencies aren't added to the additional features.
> And there's the potential case where the second call to this function could contain more core features, which the first set wouldn't get as dependencies.
> It would probably be worth atleast documenting that the second call to add a featurePath to the sec -can not- contain core features, and moving the adding of core features to the feature set outside of the if (!coreDone) block.
> *edit*
> Upon inspecting the register function and its propagation thru the whole registry setup, it seems core features -would- be added to features registered in a second registerFeatures call; However the issue that core features in a second call aren't added to the deps of all features still exists.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.