You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/09/01 09:09:00 UTC
[jira] [Work logged] (KNOX-2653) Update Atlas Service definition
for knox logout/timeout in KNOX-2625
[ https://issues.apache.org/jira/browse/KNOX-2653?focusedWorklogId=644838&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-644838 ]
ASF GitHub Bot logged work on KNOX-2653:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Sep/21 09:08
Start Date: 01/Sep/21 09:08
Worklog Time Spent: 10m
Work Description: moresandeep commented on a change in pull request #489:
URL: https://github.com/apache/knox/pull/489#discussion_r699476790
##########
File path: gateway-service-definitions/src/main/resources/services/atlas/2.1.0/rewrite.xml
##########
@@ -32,14 +32,20 @@
<rewrite template="{$frontend[path]}/atlas/"/>
</rule>
- <rule dir="OUT" name="ATLAS/atlas/outbound/login/headers/location">
- <match pattern="*://*:*/login.jsp"/>
- <rewrite template="{$frontend[url]}/atlas/login.jsp"/>
+ <rule dir="OUT" name="ATLAS/atlas/outbound/login/headers/location" flow="OR">
+ <match pattern="*://*:*/login.jsp">
+ <rewrite template="https://{$frontend[addr]}/gateway/knoxsso/knoxauth/logout.jsp?originalUrl={$postfix[url,/atlas/]}" />
+ </match>
+
+ <match pattern="*://*:*/logout.html?{**}">
+ <rewrite template="https://{$frontend[addr]}/gateway/knoxsso/knoxauth/logout.jsp?{**}"/>
Review comment:
Here we are assuming that the cluster name is `gateway` which will not be the case always.
##########
File path: gateway-service-definitions/src/main/resources/services/atlas/2.1.0/rewrite.xml
##########
@@ -32,14 +32,20 @@
<rewrite template="{$frontend[path]}/atlas/"/>
</rule>
- <rule dir="OUT" name="ATLAS/atlas/outbound/login/headers/location">
- <match pattern="*://*:*/login.jsp"/>
- <rewrite template="{$frontend[url]}/atlas/login.jsp"/>
+ <rule dir="OUT" name="ATLAS/atlas/outbound/login/headers/location" flow="OR">
+ <match pattern="*://*:*/login.jsp">
+ <rewrite template="https://{$frontend[addr]}/gateway/knoxsso/knoxauth/logout.jsp?originalUrl={$postfix[url,/atlas/]}" />
Review comment:
Here we are assuming that the cluster name is gateway which will not be the case always.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 644838)
Time Spent: 0.5h (was: 20m)
> Update Atlas Service definition for knox logout/timeout in KNOX-2625
> --------------------------------------------------------------------
>
> Key: KNOX-2653
> URL: https://issues.apache.org/jira/browse/KNOX-2653
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Nixon Rodrigues
> Assignee: Nixon Rodrigues
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> To support Knox logout/timeout in Atlas after changes in KNOX-2625 are made.
> The Atlas Service definition needs to be updated to handle knox logout/timeout scenario's
--
This message was sent by Atlassian Jira
(v8.3.4#803005)