[GitHub] [incubator-superset] villebro commented on a change in pull request #10324: feat: add optional prophet forecasting functionality to chart data api

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #10324:
URL: https://github.com/apache/incubator-superset/pull/10324#discussion_r455530912



##########
File path: superset/utils/pandas_postprocessing.py
##########
@@ -544,3 +563,105 @@ def contribution(
     if temporal_series is not None:
         contribution_df.insert(0, DTTM_ALIAS, temporal_series)
     return contribution_df
+
+
+def prophet(  # pylint: disable=too-many-arguments,too-many-locals

Review comment:
       These unfortunately need to be one single function with `too-many-arguments`, as they are called based on instructions provided in the chart data request. But you're right, `too-many-locals` doesn't need to be part of the design here, so will try to break out some internal logic.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org