You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2010/01/23 23:31:17 UTC
[jira] Commented: (ZOOKEEPER-655) StringBuffer -> StringBuilder -
conversion of references as necessary
[ https://issues.apache.org/jira/browse/ZOOKEEPER-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804163#action_12804163 ]
Hadoop QA commented on ZOOKEEPER-655:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12431226/ZOOKEEPER-655.patch
against trunk revision 902320.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/53/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/53/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/53/console
This message is automatically generated.
> StringBuffer -> StringBuilder - conversion of references as necessary
> ---------------------------------------------------------------------
>
> Key: ZOOKEEPER-655
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-655
> Project: Zookeeper
> Issue Type: Improvement
> Reporter: Kay Kay
> Attachments: ZOOKEEPER-655.patch
>
>
> Some of the 'StringBuffer' references that do not escape the scope of the method can be better typed as StringBuilder as concurrency is not needed in that case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.