[GitHub] [spark] sarutak commented on a change in pull request #31601: [SPARK-34484][SQL] Introduce a new syntax to represent attributes with the Catalyst DSL

[GitBox <gi...@apache.org>]

sarutak commented on a change in pull request #31601:
URL: https://github.com/apache/spark/pull/31601#discussion_r580244109



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/EncoderResolutionSuite.scala
##########
@@ -54,38 +54,38 @@ class EncoderResolutionSuite extends PlanTest {
     val encoder = ExpressionEncoder[StringLongClass]
 
     // int type can be up cast to long type
-    val attrs1 = Seq('a.string, 'b.int)
+    val attrs1 = Seq(attr("a").string, attr("b").int)

Review comment:
       Actually, tt's not enough. `"name".attr` returns `UnresolvedAttribute` so we still fail to `"name".attr.map`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org