You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by PramodSSImmaneni <gi...@git.apache.org> on 2016/03/25 02:26:18 UTC

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2025 Move FileLineI...

GitHub user PramodSSImmaneni opened a pull request:

    https://github.com/apache/incubator-apex-malhar/pull/220

    APEXMALHAR-2025 Move FileLineInputOperator out of AbstractFileInputOperator

    @chandnisingh please review

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PramodSSImmaneni/incubator-apex-malhar APEXMALHAR-2025

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-apex-malhar/pull/220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #220
    
----
commit d5b01da5e6e517d7b8fdaf6de0ffa13403a92ad1
Author: Pramod Immaneni <pr...@datatorrent.com>
Date:   2016-03-25T01:24:15Z

    Created a separate line by line file input reader operator

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2025 Move FileLineI...

Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/220#discussion_r57445335
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/LineByLineFileInputOperator.java ---
    @@ -0,0 +1,55 @@
    +package com.datatorrent.lib.io.fs;
    --- End diff --
    
    Thanks.. adding it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2025 Move FileLineI...

Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/220#discussion_r57445390
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/LineByLineFileInputOperator.java ---
    @@ -0,0 +1,55 @@
    +package com.datatorrent.lib.io.fs;
    +
    +import java.io.BufferedReader;
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.io.InputStreamReader;
    +
    +import org.apache.hadoop.fs.Path;
    +
    +import com.datatorrent.api.DefaultOutputPort;
    +
    +/**
    + * This is an extension of the {@link AbstractFileInputOperator} that outputs the contents of a file line by line.&nbsp;
    + * Each line is emitted as a separate tuple in string format.
    + * <p>
    + * The directory path where to scan and read files from should be specified using the {@link #directory} property.
    + * </p>
    + * @displayName File Line Input
    + * @category Input
    + * @tags fs, file, line, lines, input operator
    + */
    +public class LineByLineFileInputOperator extends AbstractFileInputOperator<String>
    --- End diff --
    
    Thought this might be more clearer.. FileLine words next to each other always felt a little weird.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2025 Move FileLineI...

Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/220#discussion_r57414100
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/LineByLineFileInputOperator.java ---
    @@ -0,0 +1,55 @@
    +package com.datatorrent.lib.io.fs;
    +
    +import java.io.BufferedReader;
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.io.InputStreamReader;
    +
    +import org.apache.hadoop.fs.Path;
    +
    +import com.datatorrent.api.DefaultOutputPort;
    +
    +/**
    + * This is an extension of the {@link AbstractFileInputOperator} that outputs the contents of a file line by line.&nbsp;
    + * Each line is emitted as a separate tuple in string format.
    + * <p>
    + * The directory path where to scan and read files from should be specified using the {@link #directory} property.
    + * </p>
    + * @displayName File Line Input
    + * @category Input
    + * @tags fs, file, line, lines, input operator
    + */
    +public class LineByLineFileInputOperator extends AbstractFileInputOperator<String>
    --- End diff --
    
    The name is quite innovative :-) 
    Is the old name not ok?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2025 Move FileLineI...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-apex-malhar/pull/220


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2025 Move FileLineI...

Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/220#discussion_r57413886
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/LineByLineFileInputOperator.java ---
    @@ -0,0 +1,55 @@
    +package com.datatorrent.lib.io.fs;
    --- End diff --
    
    No license


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---