[GitHub] [ozone] sodonnel commented on pull request #3352: HDDS-6589. Add a new replication manager and change the existing one to legacy

[GitBox <gi...@apache.org>]

sodonnel commented on PR #3352:
URL: https://github.com/apache/ozone/pull/3352#issuecomment-1110198778

   This is a very big patch that moves the ReplicationManager class to LegacyReplicationManager, but there is also a lot of change inside the moved class. It would be better if this PR was a series of commits rather than one large one (this is true for any large PR), as it makes it much easier to review. Eg 1 commit for moving ReplicationManager -> LegacyReplicationManager (probably a refactor in Intellij), then a commit for each logical set of changes. It doesn't need to be a series of Jiras, just a series of commits in the PR that are not squashed until the end.
   
   Could you re-post this as a series of commits, or do you not have the changes like that on your local branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org