[GitHub] [geode] BenjaminPerryRoss opened pull request #2954: GEODE-6066: Fixed cluster config update for error case

["BenjaminPerryRoss (GitHub)" <gi...@apache.org>]

Co-authored-by: Ben Ross <br...@pivotal.io>
Co-autored-by: Jianxia Chen <jc...@apache.org>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2954 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2954: GEODE-6066: Fixed cluster config update for error case

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

Oops, I just saw we do check "service != null. So I'd be satisfied if you just change "config" to "configuration".

[ Full content available at: https://github.com/apache/geode/pull/2954 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2954: GEODE-6066: Fixed cluster config update for error case

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

The problem I have with saying "data source saved to cluster config" is it might not happen. I suggest only adding this to the message here if "service" is not null. Even in that case should we say here: "will attempt to save to cluster configuration" instead? (Note: change "config" to "configuration" in customer facing message).
We will ask gfsh to make the attempt and it will follow it up with its own message telling us if it was saved to cluster config. It is not until "updateConfigForGroup" is called and returns true that we know the cluster config was actually saved.

[ Full content available at: https://github.com/apache/geode/pull/2954 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal closed pull request #2954: GEODE-6066: Fixed cluster config update for error case

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

[ pull request closed by dschneider-pivotal ]

[ Full content available at: https://github.com/apache/geode/pull/2954 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] BenjaminPerryRoss commented on pull request #2954: GEODE-6066: Fixed cluster config update for error case

["BenjaminPerryRoss (GitHub)" <gi...@apache.org>]

I updated this to use the term configuration rather than the abbreviation.

[ Full content available at: https://github.com/apache/geode/pull/2954 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org