[GitHub] [hudi] vinothchandar commented on a diff in pull request #7821: [MINOR] Fixing Kryo being instantiated w/ invalid `SparkConf`

["vinothchandar (via GitHub)" <gi...@apache.org>]

vinothchandar commented on code in PR #7821:
URL: https://github.com/apache/hudi/pull/7821#discussion_r1093790583


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/ProvidesHoodieConfig.scala:
##########
@@ -188,7 +188,6 @@ trait ProvidesHoodieConfig extends Logging {
         PRECOMBINE_FIELD.key -> preCombineField,
         PARTITIONPATH_FIELD.key -> partitionFieldsStr,
         PAYLOAD_CLASS_NAME.key -> payloadClassName,
-        HoodieWriteConfig.COMBINE_BEFORE_INSERT.key -> String.valueOf(hasPrecombineColumn),

Review Comment:
   why do we change this file for this PR?



##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/SerDeUtils.scala:
##########
@@ -18,18 +18,28 @@
 package org.apache.spark.sql.hudi
 
 import org.apache.hudi.common.util.BinaryUtil
-import org.apache.spark.SparkConf
+import org.apache.spark.internal.config.Kryo.KRYO_USE_POOL
+import org.apache.spark.{SparkConf, SparkEnv}
 import org.apache.spark.serializer.{KryoSerializer, SerializerInstance}
 
 import java.nio.ByteBuffer
 
 
+// TODO merge w/ SerializationUtils
 object SerDeUtils {
 
-  private val SERIALIZER_THREAD_LOCAL = new ThreadLocal[SerializerInstance] {
+  private lazy val conf = {
+    val conf = Option(SparkEnv.get)
+      // TODO elaborate

Review Comment:
   fix comment



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org