You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/02/17 17:48:35 UTC

[GitHub] [buildstream] nanonyme commented on a change in pull request #1590: Fix coverage

nanonyme commented on a change in pull request #1590:
URL: https://github.com/apache/buildstream/pull/1590#discussion_r809314584



##########
File path: tests/sourcecache/staging.py
##########
@@ -160,7 +160,7 @@ def test_staged_source_build(tmpdir, datafiles, cli):
     files = []
     for _, _, filename in os.walk(source_dir):
         files.extend(filename)
-    assert files == []
+    assert not files

Review comment:
       Consider `assert not files, files` so we get files into output.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org