You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@texera.apache.org by gi...@apache.org on 2026/07/03 00:10:55 UTC

(texera) 01/01: fix(frontend): keep admin page height consistent (#6035)

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-6035-24b587fcbf30bce1a4614a22bbf1c5a6ad1e158e
in repository https://gitbox.apache.org/repos/asf/texera.git

commit 1bee7b8af687d6a2b5a5f6288d53d3fb17121aee
Author: Amer Mukhtar <13...@users.noreply.github.com>
AuthorDate: Fri Jul 3 05:10:33 2026 +0500

    fix(frontend): keep admin page height consistent (#6035)
    
    ### What changes were proposed in this PR?
    
    The admin pages didn't all have the same height, so the layout shifted
    when switching between sections. This meant the buttons could move
    around and you'd have to move your cursor to click them.
    
    The proposed change makes the admin pages keep a consistent height, so
    the layout stays put when moving between sections. It's a small CSS
    change to the shared dashboard content area.
    
    The fix makes nz-content a bounded flex scroll container, so overflowing
    content scrolls inside the content area while the sidebar and top nav
    stay fixed and the page height stays consistent across all admin pages.
    The nz-content rule now adds min-height: 0 and flex: 1 alongside the
    existing overflow-y: auto.
    
    | After | Before |
    | --- | --- |
    | <img width="430"
    src="https://github.com/user-attachments/assets/3e4e4556-9b79-463b-b659-1a43bc7cf0aa"
    /> | <img width="430"
    src="https://github.com/user-attachments/assets/7a4d8dd6-9b2b-4696-9963-84d8c4276ff2"
    />|
    | <img width="430"
    src="https://github.com/user-attachments/assets/2b5b0041-1a55-40ec-bcb6-8036aeae1981"
    /> | <img width="430"
    src="https://github.com/user-attachments/assets/c813943f-0c9a-4df1-ac7b-51741ab0bbf4"
    /> |
    | <img width="430"
    src="https://github.com/user-attachments/assets/0af1656b-afe1-4867-90ed-13d4517fe91b"
    /> | <img width="430"
    src="https://github.com/user-attachments/assets/818c4a7b-713c-4acd-aed8-7962e2b4ae76"
    /> |
    | <img width="430"
    src="https://github.com/user-attachments/assets/c618cdaf-a28c-4640-9945-3359413a4f75"
    /> | <img width="430"
    src="https://github.com/user-attachments/assets/f81f5b6c-d39e-45e2-8528-be82b005f75b"
    /> |
    
    
    ### Any related issues, documentation, discussions?
    
    Closes #3588
    
    ### How was this PR tested?
    
    Tested manually
    
    1. Opened each admin page (Users, Executions, Gmail, Settings) and
    confirmed the page height and the top nav and search bar no longer shift
    between sections.
    2. Verified the Users page with both few and many rows: content now
    scrolls within the content area instead of growing the whole page.
    3. Checked other dashboard pages (Workflows, Datasets) to confirm no
    scrolling regressions from the shared nz-content change.
    
    
    ### Was this PR authored or co-authored using generative AI tooling?
    Nope.
---
 frontend/src/app/dashboard/component/dashboard.component.scss | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/frontend/src/app/dashboard/component/dashboard.component.scss b/frontend/src/app/dashboard/component/dashboard.component.scss
index 5df9388d67..50bee303af 100644
--- a/frontend/src/app/dashboard/component/dashboard.component.scss
+++ b/frontend/src/app/dashboard/component/dashboard.component.scss
@@ -89,6 +89,8 @@ button {
 nz-content {
   position: relative;
   overflow-y: auto;
+  min-height: 0;
+  flex: 1;
 }
 
 .page-container {