You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/05/17 05:39:48 UTC
[kudu-CR] Stop using shared_ptr
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3098
to review the following change.
Change subject: Stop using shared_ptr<DeltaIterator>
......................................................................
Stop using shared_ptr<DeltaIterator>
These objects were never shared, but shared_ptr was used long ago because we
were unable to put scoped pointers inside vectors. Now with C++11 we can use
unique_ptr and avoid these unnecessary shared_ptrs.
This might have a small performance improvement due to reduced atomics, but
more importantly it makes it obvious that these are single-owner objects.
Change-Id: I9293fe20403a21f483ec9bfe0dd39b8e614fbd68
---
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/delta_applier.cc
M src/kudu/tablet/delta_applier.h
M src/kudu/tablet/delta_compaction-test.cc
M src/kudu/tablet/delta_compaction.cc
M src/kudu/tablet/delta_compaction.h
M src/kudu/tablet/delta_iterator_merger.cc
M src/kudu/tablet/delta_iterator_merger.h
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/diskrowset.cc
12 files changed, 56 insertions(+), 49 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/3098/1
--
To view, visit http://gerrit.cloudera.org:8080/3098
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9293fe20403a21f483ec9bfe0dd39b8e614fbd68
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>