You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/05 21:42:43 UTC

[GitHub] [arrow] Dandandan commented on pull request #8842: ARROW-10812: [Rust] Make BooleanArray not a PrimitiveArray

Dandandan commented on pull request #8842:
URL: https://github.com/apache/arrow/pull/8842#issuecomment-739419870


   This is great work 👌
   
   I think indeed this gets similar results and is a more general approach to this with wins across the board. I was actually also looking at this earlier based on a comment on a PR by you before starting the other PR, but couldn't totally figure out what had to be changed in order for this to work. Are the first benchmark results just noise?
   
   I think after this, there are likely some remaining performance differences related to overhead of `append` and related functions which does some additional checks/bookkeeping, but I think we can look at that in follow-up work. Maybe we can think of similar APIs as used in `Vec`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org