You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/11 04:09:23 UTC
[GitHub] [shardingsphere] tuohai666 opened a new pull request #5522: update release guide for download url
tuohai666 opened a new pull request #5522:
URL: https://github.com/apache/shardingsphere/pull/5522
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuohai666 commented on a change in pull request #5522: update release guide for download url
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #5522:
URL: https://github.com/apache/shardingsphere/pull/5522#discussion_r422783695
##########
File path: docs/community/content/contribute/release.cn.md
##########
@@ -495,7 +495,9 @@ https://shardingsphere.apache.org/document/current/en/downloads/
https://shardingsphere.apache.org/document/current/cn/downloads/
-`最新版本`中保留两个最新的版本。Incubator阶段历史版本会自动归档到[Archive repository](https://archive.apache.org/dist/incubator/shardingsphere/)
+PGP签名文件和哈希校验文件的下载连接应该使用这个前缀： `https://downloads.apache.org/shardingsphere/`
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #5522: update release guide for download url
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5522:
URL: https://github.com/apache/shardingsphere/pull/5522#issuecomment-626469802
## Pull Request Test Coverage Report for [Build 11576](https://coveralls.io/builds/30689615)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **58.412%**
---
| Totals | [](https://coveralls.io/builds/30689615) |
| :-- | --: |
| Change from base [Build 11569](https://coveralls.io/builds/30683584): | 0.0% |
| Covered Lines: | 11756 |
| Relevant Lines: | 20126 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #5522: update release guide for download url
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5522:
URL: https://github.com/apache/shardingsphere/pull/5522#issuecomment-626469802
## Pull Request Test Coverage Report for [Build 11582](https://coveralls.io/builds/30690099)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **27** unchanged lines in **5** files lost coverage.
* Overall coverage increased (+**0.1%**) to **58.55%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/context/RuntimeContext.java](https://coveralls.io/builds/30690099/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fcontext%2FRuntimeContext.java#L100) | 1 | 95.12% |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchemaFactory.java](https://coveralls.io/builds/30690099/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchemaFactory.java#L50) | 3 | 0% |
| [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/api/yaml/YamlShardingSphereDataSourceFactory.java](https://coveralls.io/builds/30690099/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fapi%2Fyaml%2FYamlShardingSphereDataSourceFactory.java#L52) | 4 | 35.71% |
| [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/OrchestrationShardingSphereDataSourceFactory.java](https://coveralls.io/builds/30690099/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2FOrchestrationShardingSphereDataSourceFactory.java#L54) | 4 | 0% |
| [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/metadata/schema/RuleSchemaMetaDataLoader.java](https://coveralls.io/builds/30690099/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fmetadata%2Fschema%2FRuleSchemaMetaDataLoader.java#L58) | 15 | 0% |
<!-- | **Total:** | **27** | | -->
| Totals | [](https://coveralls.io/builds/30690099) |
| :-- | --: |
| Change from base [Build 11569](https://coveralls.io/builds/30683584): | 0.1% |
| Covered Lines: | 11779 |
| Relevant Lines: | 20118 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #5522: update release guide for download url
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #5522:
URL: https://github.com/apache/shardingsphere/pull/5522#discussion_r422775591
##########
File path: docs/community/content/contribute/release.cn.md
##########
@@ -495,7 +495,9 @@ https://shardingsphere.apache.org/document/current/en/downloads/
https://shardingsphere.apache.org/document/current/cn/downloads/
-`最新版本`中保留两个最新的版本。Incubator阶段历史版本会自动归档到[Archive repository](https://archive.apache.org/dist/incubator/shardingsphere/)
+PGP签名文件和哈希校验文件的下载连接应该使用这个前缀： `https://downloads.apache.org/shardingsphere/`
Review comment:
Should be `GPG`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #5522: update release guide for download url
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5522:
URL: https://github.com/apache/shardingsphere/pull/5522#issuecomment-626468920
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5522?src=pr&el=h1) Report
> Merging [#5522](https://codecov.io/gh/apache/shardingsphere/pull/5522?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/907587669ff681576df155fec4c28a734be5e89f&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5522?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5522 +/- ##
=========================================
Coverage 54.89% 54.89%
Complexity 422 422
=========================================
Files 1145 1145
Lines 20126 20126
Branches 3673 3673
=========================================
Hits 11048 11048
Misses 8384 8384
Partials 694 694
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5522?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5522?src=pr&el=footer). Last update [9075876...05500f4](https://codecov.io/gh/apache/shardingsphere/pull/5522?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org