You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/03 17:26:29 UTC
[GitHub] [superset] rusackas opened a new issue #19015: [2.0] generally remove all code marked as "deprecated" (front end)
rusackas opened a new issue #19015:
URL: https://github.com/apache/superset/issues/19015
Look for comments stating that things that will be removed for, and remove them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on issue #19015: [2.0] generally remove all code marked as "deprecated" (front end)
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #19015:
URL: https://github.com/apache/superset/issues/19015#issuecomment-1064588356
Given this discussion: https://github.com/apache/superset/pull/13305#issuecomment-812646781, we should consider remove this feature (now or 3.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #19015: [2.0] generally remove all code marked as "deprecated" (front end)
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #19015:
URL: https://github.com/apache/superset/issues/19015#issuecomment-1064313861
Consider removing Omnibar for 3.0 - @suddjian we should start 3.0 proposals board
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on issue #19015: [2.0] generally remove all code marked as "deprecated" (front end)
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #19015:
URL: https://github.com/apache/superset/issues/19015#issuecomment-1063514579
Elizabeth and I went through superset-frontend code base and found 2 deprecation candidates:
- https://github.com/apache/superset/blob/e632193eb00803594a1bbc20c2f6cb6fb29deb1f/superset-frontend/packages/superset-ui-core/src/time-format/TimeFormatterRegistrySingleton.ts#L78
in use by "OMNIBAR" feature
- https://github.com/apache/superset/blob/e6ef7da7584d6ab40ff090213b16ed0e53550ef2/superset-frontend/src/components/OmniContainer/Omnibar.tsx#L30
in use by `table`, `pivot table`, `big number` visualization.
But both of them are currently in use and no replacement code available. So we think it's not a right time to deprecate them right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #19015: [2.0] generally remove all code marked as "deprecated" (front end)
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #19015:
URL: https://github.com/apache/superset/issues/19015#issuecomment-1064591949
I believe that since it was already marked as deprecated in the code, it's fair game to remove as part of this initiative. That work could be part of this Issue, or filed a separate one if need be, but I have no objection to the removal as part of 2.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on issue #19015: [2.0] generally remove all code marked as "deprecated" (front end)
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on issue #19015:
URL: https://github.com/apache/superset/issues/19015#issuecomment-1063514579
@eschutho and I went through superset-frontend code base and found 2 deprecation candidates:
- https://github.com/apache/superset/blob/e632193eb00803594a1bbc20c2f6cb6fb29deb1f/superset-frontend/packages/superset-ui-core/src/time-format/TimeFormatterRegistrySingleton.ts#L78
in use by "OMNIBAR" feature
- https://github.com/apache/superset/blob/e6ef7da7584d6ab40ff090213b16ed0e53550ef2/superset-frontend/src/components/OmniContainer/Omnibar.tsx#L30
in use by `table`, `pivot table`, `big number` visualization.
But both of them are currently in use and no replacement code available. So we think it's not a right time to deprecate them right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian closed issue #19015: [2.0] generally remove all code marked as "deprecated" (front end)
Posted by GitBox <gi...@apache.org>.
suddjian closed issue #19015:
URL: https://github.com/apache/superset/issues/19015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #19015: [2.0] generally remove all code marked as "deprecated" (front end)
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #19015:
URL: https://github.com/apache/superset/issues/19015#issuecomment-1064312763
Sweep through and change any comments like "will be deprecated in 2.0" to be "will be deprecated in a future version"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org