You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Krista Baker (JIRA)" <de...@beehive.apache.org> on 2006/02/17 23:26:30 UTC

[jira] Created: (BEEHIVE-1070) bindingUpdateErrors expression="${aValue}" always returns tag error

bindingUpdateErrors expression="${aValue}" always returns tag error
-------------------------------------------------------------------

         Key: BEEHIVE-1070
         URL: http://issues.apache.org/jira/browse/BEEHIVE-1070
     Project: Beehive
        Type: Bug
  Components: NetUI  
    Versions: 1.0.1    
    Reporter: Krista Baker
     Fix For: v.next


As listed in the JSP tag documentation, the following tag will always produce a tag error 
<netui:bindingUpdateErrors expression="${actionForm.firstName}"/>
with a message of: Attribute 'expression' is required to have a value. The value "" is illegal. This is often caused by binding to an object with a null value.
If the above expression="${actionForm.firstName}" is changed to "actionForm.firstName", the expected behavior will be observed.

The netui test of coretags/binding/nullbinding is an example of this where the error is seen only because the expression="${ }".  
>From this index.jsp:
  <li><netui:bindingUpdateErrors expression="${pageFlow.nullValue}" /> -- Binding Errors</li>

Even though the value remains null, if the expression is changed to the following, 
  <li><netui:bindingUpdateErrors expression="pageFlow.nullValue" /> -- Binding Errors</li>
the error will not occur even though the pageFlow value is still null.

There are three netui testRecorder tests that use this element and attribute combination:
coretags/binding/nullbinding - uses expression="${}"
coretags/binding/report - uses expression=""
tags/bindingUpdateErrors - uses expression=""

I am not sure if the example in the docs (http://beehive.apache.org/docs/1.0.1/netui/apidocs/taglib/beehive.apache.org/netui/tags-html-1.0/bindingUpdateErrors.html) and the nullbinding test are incorrect or if it is the other way around that the other two tests, even though currently producing expected results, are wrong.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (BEEHIVE-1070) bindingUpdateErrors expression="${aValue}" always returns tag error

Posted by "Eddie O'Neil (JIRA)" <de...@beehive.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-1070?page=all ]
     
Eddie O'Neil resolved BEEHIVE-1070:
-----------------------------------

    Resolution: Fixed

I fixed the documentation problem here and added a little more clarification around the use of the expression attribute value.

> bindingUpdateErrors expression="${aValue}" always returns tag error
> -------------------------------------------------------------------
>
>          Key: BEEHIVE-1070
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-1070
>      Project: Beehive
>         Type: Bug

>   Components: NetUI
>     Versions: 1.0.1
>     Reporter: Krista Baker
>      Fix For: v.next

>
> As listed in the JSP tag documentation, the following tag will always produce a tag error 
> <netui:bindingUpdateErrors expression="${actionForm.firstName}"/>
> with a message of: Attribute 'expression' is required to have a value. The value "" is illegal. This is often caused by binding to an object with a null value.
> If the above expression="${actionForm.firstName}" is changed to "actionForm.firstName", the expected behavior will be observed.
> The netui test of coretags/binding/nullbinding is an example of this where the error is seen only because the expression="${ }".  
> From this index.jsp:
>   <li><netui:bindingUpdateErrors expression="${pageFlow.nullValue}" /> -- Binding Errors</li>
> Even though the value remains null, if the expression is changed to the following, 
>   <li><netui:bindingUpdateErrors expression="pageFlow.nullValue" /> -- Binding Errors</li>
> the error will not occur even though the pageFlow value is still null.
> There are three netui testRecorder tests that use this element and attribute combination:
> coretags/binding/nullbinding - uses expression="${}"
> coretags/binding/report - uses expression=""
> tags/bindingUpdateErrors - uses expression=""
> I am not sure if the example in the docs (http://beehive.apache.org/docs/1.0.1/netui/apidocs/taglib/beehive.apache.org/netui/tags-html-1.0/bindingUpdateErrors.html) and the nullbinding test are incorrect or if it is the other way around that the other two tests, even though currently producing expected results, are wrong.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (BEEHIVE-1070) bindingUpdateErrors expression="${aValue}" always returns tag error

Posted by "Krista Baker (JIRA)" <de...@beehive.apache.org>.
    [ http://issues.apache.org/jira/browse/BEEHIVE-1070?page=comments#action_12368569 ] 

Krista Baker commented on BEEHIVE-1070:
---------------------------------------

Any updates on which is the proper behavior for this tag?  The documentation example or the current implementation?
-Thanks!

> bindingUpdateErrors expression="${aValue}" always returns tag error
> -------------------------------------------------------------------
>
>          Key: BEEHIVE-1070
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-1070
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: 1.0.1
>     Reporter: Krista Baker
>      Fix For: v.next

>
> As listed in the JSP tag documentation, the following tag will always produce a tag error 
> <netui:bindingUpdateErrors expression="${actionForm.firstName}"/>
> with a message of: Attribute 'expression' is required to have a value. The value "" is illegal. This is often caused by binding to an object with a null value.
> If the above expression="${actionForm.firstName}" is changed to "actionForm.firstName", the expected behavior will be observed.
> The netui test of coretags/binding/nullbinding is an example of this where the error is seen only because the expression="${ }".  
> From this index.jsp:
>   <li><netui:bindingUpdateErrors expression="${pageFlow.nullValue}" /> -- Binding Errors</li>
> Even though the value remains null, if the expression is changed to the following, 
>   <li><netui:bindingUpdateErrors expression="pageFlow.nullValue" /> -- Binding Errors</li>
> the error will not occur even though the pageFlow value is still null.
> There are three netui testRecorder tests that use this element and attribute combination:
> coretags/binding/nullbinding - uses expression="${}"
> coretags/binding/report - uses expression=""
> tags/bindingUpdateErrors - uses expression=""
> I am not sure if the example in the docs (http://beehive.apache.org/docs/1.0.1/netui/apidocs/taglib/beehive.apache.org/netui/tags-html-1.0/bindingUpdateErrors.html) and the nullbinding test are incorrect or if it is the other way around that the other two tests, even though currently producing expected results, are wrong.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (BEEHIVE-1070) bindingUpdateErrors expression="${aValue}" always returns tag error

Posted by "Eddie O'Neil (JIRA)" <de...@beehive.apache.org>.
    [ http://issues.apache.org/jira/browse/BEEHIVE-1070?page=comments#action_12377608 ] 

Eddie O'Neil commented on BEEHIVE-1070:
---------------------------------------

Krista -- after looking at this, I think that the documentation is incorrect.  This tag's "expression" attribute should resolve to a NetUI expression because it's specified in the tag as:

  <netui:bindingUpdateErrors expression="actionForm.foo"/>

or because the container executes a JSP 2.0 expression whose value is a NetUI expression:

  <% pageContext.setAttribute("theexpression", "actionForm.foo");%>
  <netui:bindingUpdateErrors expression="${theexpression}"/>

The exception is caused because the "expression" attribute requires a value.  Iroincally, I think that the real bug is that the <bindingUpdateErrors> tag should have runtime expressions disabled.  I'll make both of these changes -- disabling runtime expressions and the documentation fix.

> bindingUpdateErrors expression="${aValue}" always returns tag error
> -------------------------------------------------------------------
>
>          Key: BEEHIVE-1070
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-1070
>      Project: Beehive
>         Type: Bug

>   Components: NetUI
>     Versions: 1.0.1
>     Reporter: Krista Baker
>      Fix For: v.next

>
> As listed in the JSP tag documentation, the following tag will always produce a tag error 
> <netui:bindingUpdateErrors expression="${actionForm.firstName}"/>
> with a message of: Attribute 'expression' is required to have a value. The value "" is illegal. This is often caused by binding to an object with a null value.
> If the above expression="${actionForm.firstName}" is changed to "actionForm.firstName", the expected behavior will be observed.
> The netui test of coretags/binding/nullbinding is an example of this where the error is seen only because the expression="${ }".  
> From this index.jsp:
>   <li><netui:bindingUpdateErrors expression="${pageFlow.nullValue}" /> -- Binding Errors</li>
> Even though the value remains null, if the expression is changed to the following, 
>   <li><netui:bindingUpdateErrors expression="pageFlow.nullValue" /> -- Binding Errors</li>
> the error will not occur even though the pageFlow value is still null.
> There are three netui testRecorder tests that use this element and attribute combination:
> coretags/binding/nullbinding - uses expression="${}"
> coretags/binding/report - uses expression=""
> tags/bindingUpdateErrors - uses expression=""
> I am not sure if the example in the docs (http://beehive.apache.org/docs/1.0.1/netui/apidocs/taglib/beehive.apache.org/netui/tags-html-1.0/bindingUpdateErrors.html) and the nullbinding test are incorrect or if it is the other way around that the other two tests, even though currently producing expected results, are wrong.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (BEEHIVE-1070) bindingUpdateErrors expression="${aValue}" always returns tag error

Posted by "Eddie O'Neil (JIRA)" <de...@beehive.apache.org>.
    [ http://issues.apache.org/jira/browse/BEEHIVE-1070?page=comments#action_12377610 ] 

Eddie O'Neil commented on BEEHIVE-1070:
---------------------------------------

Krista -- one quick update.  We've actually got a test that verifies that the ${...} produces the appropriate error on the "expression" attribute.  So, I'm going to leave the runtime expression-ability of this attribute as is and just fix the documentation.  It will still produce the error if bound to ${aValue} as above, but that's what it's supposed to do.  :)

> bindingUpdateErrors expression="${aValue}" always returns tag error
> -------------------------------------------------------------------
>
>          Key: BEEHIVE-1070
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-1070
>      Project: Beehive
>         Type: Bug

>   Components: NetUI
>     Versions: 1.0.1
>     Reporter: Krista Baker
>      Fix For: v.next

>
> As listed in the JSP tag documentation, the following tag will always produce a tag error 
> <netui:bindingUpdateErrors expression="${actionForm.firstName}"/>
> with a message of: Attribute 'expression' is required to have a value. The value "" is illegal. This is often caused by binding to an object with a null value.
> If the above expression="${actionForm.firstName}" is changed to "actionForm.firstName", the expected behavior will be observed.
> The netui test of coretags/binding/nullbinding is an example of this where the error is seen only because the expression="${ }".  
> From this index.jsp:
>   <li><netui:bindingUpdateErrors expression="${pageFlow.nullValue}" /> -- Binding Errors</li>
> Even though the value remains null, if the expression is changed to the following, 
>   <li><netui:bindingUpdateErrors expression="pageFlow.nullValue" /> -- Binding Errors</li>
> the error will not occur even though the pageFlow value is still null.
> There are three netui testRecorder tests that use this element and attribute combination:
> coretags/binding/nullbinding - uses expression="${}"
> coretags/binding/report - uses expression=""
> tags/bindingUpdateErrors - uses expression=""
> I am not sure if the example in the docs (http://beehive.apache.org/docs/1.0.1/netui/apidocs/taglib/beehive.apache.org/netui/tags-html-1.0/bindingUpdateErrors.html) and the nullbinding test are incorrect or if it is the other way around that the other two tests, even though currently producing expected results, are wrong.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira