[jira] [Commented] (CASSANDRA-9292) ParentRepairSession potentially block ANTI_ENTROPY stage

["Blake Eggleston (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-9292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878898#comment-15878898 ] 

Blake Eggleston commented on CASSANDRA-9292:
--------------------------------------------

I don't see anything in the prepare path we need to synchronize for, so this looks good, with the exception of [this wait|https://github.com/krummas/cassandra/blob/marcuse/9292/src/java/org/apache/cassandra/service/ActiveRepairService.java#L379]. Could you set  that to {{DatabaseDescriptor.getRpcTimeout()}} as well?

> ParentRepairSession potentially block ANTI_ENTROPY stage
> --------------------------------------------------------
>
>                 Key: CASSANDRA-9292
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9292
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Yuki Morishita
>            Assignee: Marcus Eriksson
>            Priority: Minor
>             Fix For: 4.x
>
>
> Follow up from CASSANDRA-9151,
> {quote}
> potentially block this stage again since many methods are synchronized in ActiveRepairService.
> Methods prepareForRepair(could block for 1 hour for prepare message response) and finishParentSession(this one block for anticompaction to finish) are synchronized and could hold on to the lock for a long time.
> In RepairMessageVerbHandler.doVerb, if there is an exception for another repair, removeParentRepairSession(also synchronized) will block.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)