You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/02/15 11:36:00 UTC

[GitHub] marcoabreu commented on issue #14176: uncomment memory pool free

marcoabreu commented on issue #14176: uncomment memory pool free
URL: https://github.com/apache/incubator-mxnet/pull/14176#issuecomment-464014119
 
 
   Hi,
   
   thanks a lot for your input. We already have an ASAN setup ready in CI, but it is set as non blocking:
   
   https://github.com/apache/incubator-mxnet/blob/master/ci/docker/runtime_functions.sh#L409
   https://github.com/apache/incubator-mxnet/blob/master/ci/docker/runtime_functions.sh#L1021
   
   I'd recommend to enable the blocking for memory leaks and then incrementally work in your PR to address these leaks until CI is green. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services