You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by danielvdende <gi...@git.apache.org> on 2018/01/03 17:41:56 UTC

[GitHub] spark issue #20057: [SPARK-22880][SQL] Add cascadeTruncate option to JDBC da...

Github user danielvdende commented on the issue:

    https://github.com/apache/spark/pull/20057
  
    I've made some changes to the code; the hardcoded `false` value for `cascade` in `JdbcDialects` is now replaced by a default value of `isCascadingTruncateTable`. This is also the case for each individual dialect, with a pattern match in the dialects for Postgres and Oracle, as they support the cascading behaviour. Curious to hear your thoughts on this @dongjoon-hyun @gatorsmile 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org