You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2014/10/09 07:40:31 UTC

Review Request 26482: CLOUDSTACK-7688: Do not allow various operations which breaks VM Snapshots

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26482/
-----------------------------------------------------------

Review request for cloudstack, anthony xu and Devdeep Singh.


Bugs: CLOUDSTACK-7688
    https://issues.apache.org/jira/browse/CLOUDSTACK-7688


Repository: cloudstack-git


Description
-------

VM snapshots stops working when following operations are performed on VM with VM snapshots

1. Volumes of VM are migrated to other storage
2. Add and remove NIC to/from VM
3. Attach and Detach volume to VM
4. Scale up/down of VM(change service offering)
5. Volume snapshot which is not major use case in this scenario
6. Resize volume
7. Live migration of VM which involves storage migration

This patche adds the above restrictions


Diffs
-----

  server/src/com/cloud/storage/VolumeApiServiceImpl.java e089b77 
  server/src/com/cloud/vm/UserVmManagerImpl.java 2636096 

Diff: https://reviews.apache.org/r/26482/diff/


Testing
-------

verified that all the above operations are not allowed


Thanks,

Anshul Gangwar


Re: Review Request 26482: CLOUDSTACK-7688: Do not allow various operations which breaks VM Snapshots

Posted by anthony xu <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26482/#review56739
-----------------------------------------------------------

Ship it!


Ship It!

- anthony xu


On Oct. 9, 2014, 9:09 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26482/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 9:09 a.m.)
> 
> 
> Review request for cloudstack, anthony xu and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-7688
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7688
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> VM snapshots stops working when following operations are performed on VM with VM snapshots
> 
> 1. Volumes of VM are migrated to other storage
> 2. Add and remove NIC to/from VM
> 3. Attach and Detach volume to VM
> 4. Scale up/down of VM(change service offering)
> 5. Volume snapshot which is not major use case in this scenario
> 6. Resize volume
> 7. Live migration of VM which involves storage migration
> 8. Do not allow VM snapshot in case VM snapshot already exists
> 
> This patche adds the above restrictions
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/VolumeApiServiceImpl.java e089b77 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 2636096 
>   server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java f85f6c8 
> 
> Diff: https://reviews.apache.org/r/26482/diff/
> 
> 
> Testing
> -------
> 
> verified that all the above operations are not allowed
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Re: Review Request 26482: CLOUDSTACK-7688: Do not allow various operations which breaks VM Snapshots

Posted by Anshul Gangwar <an...@citrix.com>.

> On Oct. 10, 2014, 6:15 p.m., anthony xu wrote:
> > Can you explain why you remove the code?
> >  // remove diskAndMemory VM snapshots

Removed code was removing VM snapshots without user knowing.
Now we are not allowing user to upgrade/scale VM when it has VM snapshots.
So this code will not be doing anything( kind of dead code).


- Anshul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26482/#review56181
-----------------------------------------------------------


On Oct. 9, 2014, 9:09 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26482/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 9:09 a.m.)
> 
> 
> Review request for cloudstack, anthony xu and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-7688
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7688
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> VM snapshots stops working when following operations are performed on VM with VM snapshots
> 
> 1. Volumes of VM are migrated to other storage
> 2. Add and remove NIC to/from VM
> 3. Attach and Detach volume to VM
> 4. Scale up/down of VM(change service offering)
> 5. Volume snapshot which is not major use case in this scenario
> 6. Resize volume
> 7. Live migration of VM which involves storage migration
> 8. Do not allow VM snapshot in case VM snapshot already exists
> 
> This patche adds the above restrictions
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/VolumeApiServiceImpl.java e089b77 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 2636096 
>   server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java f85f6c8 
> 
> Diff: https://reviews.apache.org/r/26482/diff/
> 
> 
> Testing
> -------
> 
> verified that all the above operations are not allowed
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Re: Review Request 26482: CLOUDSTACK-7688: Do not allow various operations which breaks VM Snapshots

Posted by anthony xu <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26482/#review56181
-----------------------------------------------------------


Can you explain why you remove the code?
 // remove diskAndMemory VM snapshots

- anthony xu


On Oct. 9, 2014, 9:09 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26482/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 9:09 a.m.)
> 
> 
> Review request for cloudstack, anthony xu and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-7688
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7688
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> VM snapshots stops working when following operations are performed on VM with VM snapshots
> 
> 1. Volumes of VM are migrated to other storage
> 2. Add and remove NIC to/from VM
> 3. Attach and Detach volume to VM
> 4. Scale up/down of VM(change service offering)
> 5. Volume snapshot which is not major use case in this scenario
> 6. Resize volume
> 7. Live migration of VM which involves storage migration
> 8. Do not allow VM snapshot in case VM snapshot already exists
> 
> This patche adds the above restrictions
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/VolumeApiServiceImpl.java e089b77 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 2636096 
>   server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java f85f6c8 
> 
> Diff: https://reviews.apache.org/r/26482/diff/
> 
> 
> Testing
> -------
> 
> verified that all the above operations are not allowed
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Re: Review Request 26482: CLOUDSTACK-7688: Do not allow various operations which breaks VM Snapshots

Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26482/
-----------------------------------------------------------

(Updated Oct. 9, 2014, 9:09 a.m.)


Review request for cloudstack, anthony xu and Devdeep Singh.


Changes
-------

updated the patch to not allow vm snapshots in case volume snapshot for that VM already exists


Bugs: CLOUDSTACK-7688
    https://issues.apache.org/jira/browse/CLOUDSTACK-7688


Repository: cloudstack-git


Description (updated)
-------

VM snapshots stops working when following operations are performed on VM with VM snapshots

1. Volumes of VM are migrated to other storage
2. Add and remove NIC to/from VM
3. Attach and Detach volume to VM
4. Scale up/down of VM(change service offering)
5. Volume snapshot which is not major use case in this scenario
6. Resize volume
7. Live migration of VM which involves storage migration
8. Do not allow VM snapshot in case VM snapshot already exists

This patche adds the above restrictions


Diffs (updated)
-----

  server/src/com/cloud/storage/VolumeApiServiceImpl.java e089b77 
  server/src/com/cloud/vm/UserVmManagerImpl.java 2636096 
  server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java f85f6c8 

Diff: https://reviews.apache.org/r/26482/diff/


Testing
-------

verified that all the above operations are not allowed


Thanks,

Anshul Gangwar