You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/17 21:26:02 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #8213: Better
distinction between tables and views, and show CREATE VIEW
codecov-io commented on issue #8213: Better distinction between tables and views, and show CREATE VIEW
URL: https://github.com/apache/incubator-superset/pull/8213#issuecomment-532408612
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8213?src=pr&el=h1) Report
> Merging [#8213](https://codecov.io/gh/apache/incubator-superset/pull/8213?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4132d8fb0f7d79556e4ecf6199e0611da5303aea?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8213 +/- ##
==========================================
- Coverage 65.79% 65.72% -0.07%
==========================================
Files 480 481 +1
Lines 23273 23317 +44
Branches 2567 2572 +5
==========================================
+ Hits 15312 15326 +14
- Misses 7823 7853 +30
Partials 138 138
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1RhYmxlU2VsZWN0b3IuanN4) | `77.69% <0%> (-6.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.61% <40%> (-0.49%)` | :arrow_down: |
| [...rset/assets/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9UYWJsZUVsZW1lbnQuanN4) | `83.52% <50%> (-0.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `72.37% <53.33%> (-1.48%)` | :arrow_down: |
| [superset/assets/src/SqlLab/components/ShowSQL.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8213/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TaG93U1FMLmpzeA==) | `55.55% <55.55%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8213?src=pr&el=footer). Last update [4132d8f...d93c426](https://codecov.io/gh/apache/incubator-superset/pull/8213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org