You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/06 19:35:06 UTC
[GitHub] [superset] jinghua-qa opened a new issue #16995: [Explore] Owner can not change the name by just clicking on the title
jinghua-qa opened a new issue #16995:
URL: https://github.com/apache/superset/issues/16995
Owner can not do click edit when open a saved chart any more, can only do click edit when creating a new chart.
#### How to reproduce the bug
1, Explore saved chart own by you
2, Hover mouse over to chart's title
3, Click on chart title
### Expected results
1,Should see tooltip "Click to edit"
2,Title is successfully edit and saved
### Actual results
There is no opportunity to edit chart title by click
#### Screenshots
### Environment
(please complete the following information):
- browser type and version: Chrome
- superset version: master
- python version: `python --version`
- node.js version: `node -v`
- any feature flags active:
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc closed issue #16995: [Explore] Owner can not change the name by just clicking on the title
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #16995:
URL: https://github.com/apache/superset/issues/16995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] belgren commented on issue #16995: [Explore] Owner can not change the name by just clicking on the title
Posted by GitBox <gi...@apache.org>.
belgren commented on issue #16995:
URL: https://github.com/apache/superset/issues/16995#issuecomment-937981060
Hi, I'd like to work on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jayakrishnankk commented on issue #16995: [Explore] Owner can not change the name by just clicking on the title
Posted by GitBox <gi...@apache.org>.
jayakrishnankk commented on issue #16995:
URL: https://github.com/apache/superset/issues/16995#issuecomment-978185447
@jinghua-qa - I believe this can be closed since the related pull request is now merged. #17047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] belgren commented on issue #16995: [Explore] Owner can not change the name by just clicking on the title
Posted by GitBox <gi...@apache.org>.
belgren commented on issue #16995:
URL: https://github.com/apache/superset/issues/16995#issuecomment-939214348
@junlincc @jinghua-qa I opened a [draft pr](https://github.com/apache/superset/pull/17047) to explicitly allow owners of the chart to edit the title. If this approach makes sense, I'll change the status from draft to ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16995: [Explore] Owner can not change the name by just clicking on the title
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16995:
URL: https://github.com/apache/superset/issues/16995#issuecomment-978217762
@belgren Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] belgren commented on issue #16995: [Explore] Owner can not change the name by just clicking on the title
Posted by GitBox <gi...@apache.org>.
belgren commented on issue #16995:
URL: https://github.com/apache/superset/issues/16995#issuecomment-937981060
Hi, I'd like to work on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lukajeza commented on issue #16995: [Explore] Owner can not change the name by just clicking on the title
Posted by GitBox <gi...@apache.org>.
lukajeza commented on issue #16995:
URL: https://github.com/apache/superset/issues/16995#issuecomment-939130721
With JS make the text clickable, when clicked turn it in to an input field and make a save button appear. The save button should send a post request to make a change to the name in the database and redirect you back to the same page in order to apply the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] belgren removed a comment on issue #16995: [Explore] Owner can not change the name by just clicking on the title
Posted by GitBox <gi...@apache.org>.
belgren removed a comment on issue #16995:
URL: https://github.com/apache/superset/issues/16995#issuecomment-939214348
@junlincc @jinghua-qa I opened a [draft pr](https://github.com/apache/superset/pull/17047) to explicitly allow owners of the chart to edit the title. If this approach makes sense, I'll change the status from draft to ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org