You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/12/08 09:52:36 UTC

[GitHub] [nuttx] anchao commented on a diff in pull request #7817: risc-v/es32c3: improve passthrough performance by iob offload

anchao commented on code in PR #7817:
URL: https://github.com/apache/nuttx/pull/7817#discussion_r1043146535


##########
arch/risc-v/src/esp32c3/esp32c3_wlan.c:
##########
@@ -691,27 +486,9 @@ static void wlan_rxpoll(void *arg)
       pkt_input(&priv->dev);
 #endif
 
-      /* Check if the packet is a valid size for the network
-       * buffer configuration (this should not happen)
-       */
-
-      if (dev->d_len > WLAN_BUF_SIZE)
-        {
-          nwarn("WARNING: DROPPED Too big: %d\n", dev->d_len);
-
-          /* Free dropped packet buffer */
-
-          if (dev->d_buf)
-            {
-              wlan_free_buffer(priv, dev->d_buf);
-              dev->d_buf = NULL;
-              dev->d_len = 0;
-            }
-
-          continue;
-        }
-
-      eth_hdr = (struct eth_hdr_s *)dev->d_buf;
+      eth_hdr = (struct eth_hdr_s *)
+        &dev->d_iob->io_data[CONFIG_NET_LL_GUARDSIZE -
+                             NET_LL_HDRLEN(dev)];

Review Comment:
   ETHBUF was moved to internal header, so ETHBUF can no longer be used from arch driver  :)
   https://github.com/apache/nuttx/blob/62004a28a68f47f0c6f31c9e050555997bfbca06/net/devif/devif.h#L240
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org