You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/09/22 09:36:18 UTC

[GitHub] [couchdb] iilyak commented on a change in pull request #3164: Feature ebtree views

iilyak commented on a change in pull request #3164:
URL: https://github.com/apache/couchdb/pull/3164#discussion_r492600845



##########
File path: src/couch_views/test/couch_views_indexer_test.erl
##########
@@ -388,8 +384,8 @@ multiple_design_docs(Db) ->
 
     % This is how we check that no index updates took place
     meck:new(couch_views_fdb, [passthrough]),
-    meck:expect(couch_views_fdb, write_doc, fun(TxDb, Sig, ViewIds, Doc) ->
-        meck:passthrough([TxDb, Sig, ViewIds, Doc])
+    meck:expect(couch_views_fdb, update_views, fun(TxDb, Mrst, Docs) ->

Review comment:
       This is confusing.  We create an `expect` for an `update_views`, but use `meck:num_calls/3` on `write_doc`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org