You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "sseveran (via GitHub)" <gi...@apache.org> on 2025/09/23 20:36:08 UTC

[D] Running the Gradle Plugin tests [pekko-grpc]

GitHub user sseveran created a discussion: Running the Gradle Plugin tests

Hi. I am hoping to contribute a small fix to enable the gradle plugin to make it work correctly with the gradle [configuration cache](https://docs.gradle.org/current/userguide/configuration_cache.html). The fix is pretty trivial and I have tested it with my internal project.

I have run in to something of an issue with actually writing a test to accompany my PR. It does not appear to me that the tests for the gradle plugin are actually running in the CI. For instance I don't see anything related to the GradleCompatibilitySpec even when I run gradle with --debug.

What tests are actually supposed to be run in the CI? I can carve out some more time to spend on this if someone can help me understand the testing procedure here.

GitHub link: https://github.com/apache/pekko-grpc/discussions/516

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [D] Running the Gradle Plugin tests [pekko-grpc]

Posted by "raboof (via GitHub) via notifications" <no...@pekko.apache.org>.
GitHub user raboof added a comment to the discussion: Running the Gradle Plugin tests

@sseveran I'm curious what sparked your interest in the Pekko gRPC Gradle plugin - as far as I've seen we have never released it yet?

GitHub link: https://github.com/apache/pekko-grpc/discussions/516#discussioncomment-19757118

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [D] Running the Gradle Plugin tests [pekko-grpc]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
GitHub user He-Pin added a comment to the discussion: Running the Gradle Plugin tests

I think you can just end the pr,if test is not easy to write, just add some inline comments should be OK 

GitHub link: https://github.com/apache/pekko-grpc/discussions/516#discussioncomment-14490734

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [D] Running the Gradle Plugin tests [pekko-grpc]

Posted by "pjfanning (via GitHub) via notifications" <no...@pekko.apache.org>.
GitHub user pjfanning added a comment to the discussion: Running the Gradle Plugin tests

I think there is a shortcoming in the CI job to produce the release artifacts. I am attempting to release 2.0.0 gradle plugin manually now and will later look at the CI job to see if it can be fixed. The gradle plugin I am releasing is based on the v2.0.0 tag but built on my laptop.

GitHub link: https://github.com/apache/pekko-grpc/discussions/516#discussioncomment-19759246

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [D] Running the Gradle Plugin tests [pekko-grpc]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
GitHub user pjfanning added a comment to the discussion: Running the Gradle Plugin tests

The CI builds appear to run the Gradle tests ok. I see them running in the logs but the output is not very detailed and it could be that some tests are skipped. I don't have time today to run them locally.
https://github.com/apache/pekko-grpc/blob/main/.github/workflows/build-test.yml#L152-L209


GitHub link: https://github.com/apache/pekko-grpc/discussions/516#discussioncomment-14491093

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [D] Running the Gradle Plugin tests [pekko-grpc]

Posted by "raboof (via GitHub) via notifications" <no...@pekko.apache.org>.
GitHub user raboof edited a comment on the discussion: Running the Gradle Plugin tests

@sseveran I'm curious what sparked your interest in the Pekko gRPC Gradle plugin - as far as I've seen we have never released it yet? Would you like to use it if we did release it?

GitHub link: https://github.com/apache/pekko-grpc/discussions/516#discussioncomment-19757118

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org