You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "gyfora (via GitHub)" <gi...@apache.org> on 2023/04/26 06:40:28 UTC
[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #576: [FLINK-31886] Bump fabric8 and josdk version
gyfora opened a new pull request, #576:
URL: https://github.com/apache/flink-kubernetes-operator/pull/576
## What is the purpose of the change
Update our kubernetes dependencies to the latest and greatest
## Verifying this change
Existing tests cover the current behaviour
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changes to the `CustomResourceDescriptors`: no
- Core observer or reconciler logic that is regularly executed: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #576: [FLINK-31886] Bump fabric8 and josdk version
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora commented on code in PR #576:
URL: https://github.com/apache/flink-kubernetes-operator/pull/576#discussion_r1177506567
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/TestUtils.java:
##########
@@ -397,5 +398,10 @@ public ManagedDependentResourceContext managedDependentResourceContext() {
public EventSourceRetriever<T> eventSourceRetriever() {
return null;
}
+
+ @Override
+ public KubernetesClient getClient() {
+ throw new UnsupportedOperationException("Not implemented");
+ }
Review Comment:
The josdk Context interface added a new method to access the client, we need to implement it in our tests but we are not using it yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #576: [FLINK-31886] Bump fabric8 and josdk version
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora commented on PR #576:
URL: https://github.com/apache/flink-kubernetes-operator/pull/576#issuecomment-1523042788
> Thanks, using this to verify @gaborgsomogyi's committership privileges. 😏
let's gooo 🚢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on a diff in pull request #576: [FLINK-31886] Bump fabric8 and josdk version
Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on code in PR #576:
URL: https://github.com/apache/flink-kubernetes-operator/pull/576#discussion_r1177452047
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/TestUtils.java:
##########
@@ -397,5 +398,10 @@ public ManagedDependentResourceContext managedDependentResourceContext() {
public EventSourceRetriever<T> eventSourceRetriever() {
return null;
}
+
+ @Override
+ public KubernetesClient getClient() {
+ throw new UnsupportedOperationException("Not implemented");
+ }
Review Comment:
Why do we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #576: [FLINK-31886] Bump fabric8 and josdk version
Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #576:
URL: https://github.com/apache/flink-kubernetes-operator/pull/576#issuecomment-1522918007
Looks good, but CI is failing so restarted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #576: [FLINK-31886] Bump fabric8 and josdk version
Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #576:
URL: https://github.com/apache/flink-kubernetes-operator/pull/576#issuecomment-1522955983
```
2023-04-26T07:40:21.5290369Z Please generate the java doc via 'mvn clean install -DskipTests -Pgenerate-docs' again
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gaborgsomogyi merged pull request #576: [FLINK-31886] Bump fabric8 and josdk version
Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi merged PR #576:
URL: https://github.com/apache/flink-kubernetes-operator/pull/576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #576: [FLINK-31886] Bump fabric8 and josdk version
Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #576:
URL: https://github.com/apache/flink-kubernetes-operator/pull/576#issuecomment-1523061956
:shipit:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org