You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/03/05 06:52:14 UTC

[GitHub] michaelsembwever commented on issue #878: Add the third Party Components description into notice file.

michaelsembwever commented on issue #878: Add the third Party Components description into notice file.
URL: https://github.com/apache/incubator-skywalking/pull/878#issuecomment-370325836
 
 
   side-note: it's not normal git practice to merge master to feature/bug branches. That is this commit 57768898702d6a9e6ae78fc88caf1ede92249306 would not appear in most project's pull requests. It's more typical that pull request branches are rebased off master. The underlying reasoning to this is bi-directional merges is problematic. More info on this is in https://www.youtube.com/watch?v=AJ-CpGsCpM0
   Maybe SkyWalking has established a different set of practices, if so then do please take this feedback with a grain of salt, otherwise it might be relevant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services