[GitHub] [incubator-gobblin] aplex commented on a change in pull request #3196: [GOBBLIN-1357] Updates k8s and docker GaaS to use up-to-date images and non-deprecated ingress

[GitBox <gi...@apache.org>]

aplex commented on a change in pull request #3196:
URL: https://github.com/apache/incubator-gobblin/pull/3196#discussion_r555361292



##########
File path: gobblin-kubernetes/gobblin-service/mysql-cluster/mysql-deployment.yaml
##########
@@ -30,7 +30,7 @@ spec:
           persistentVolumeClaim:
             claimName: mysql-pv-claim
       containers:
-        - image: mysql:5.6.45
+        - image: mysql:5.7.32

Review comment:
       I think we migrated to 8.x this year

##########
File path: gobblin-kubernetes/gobblin-service/base-cluster/deployment.yaml
##########
@@ -57,7 +59,12 @@ spec:
             claimName: shared-jobs-claim
       containers:
         - name: gobblin-standalone
-          image: will97/gobblin-standalone:latest
+          image: apache/gobblin:latest
+          args: ["--mode", "standalone", "--jvmopts", "-XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap"]
           volumeMounts:
             - name: shared-jobs
               mountPath: /tmp/gobblin-standalone/jobs
+          env:
+            - name: GOBBLIN_JOB_CONFIG_DIR
+              value: /tmp/gobblin-standalone/jobs

Review comment:
       /tmp/ is not a good place to store configuration, as it can get cleaned up at any moment - https://serverfault.com/questions/377348/when-does-tmp-get-cleared
   
   If those configs rarely change while container is running, you can put them in /etc/gobblin . For files that are constantly changing , use /var/... 
   
   See https://en.wikipedia.org/wiki/Filesystem_Hierarchy_Standard for explanation of linux file system structure




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org