[GitHub] [pulsar] lhotari commented on pull request #20433: [improve][build] Improve the publishing of docker image

["lhotari (via GitHub)" <gi...@apache.org>]

lhotari commented on PR #20433:
URL: https://github.com/apache/pulsar/pull/20433#issuecomment-1567393426

   > * Use `apachepulsar/pulsar:${PULSAR_VERSION}` instead of `apachepulsar/pulsar:latest` in the `docker/pulsar-all/Dockerfile`, I expect to be able to use the correct pulsar image.
   
   I support this change, but the usage of `apachepulsar/pulsar:latest` in  `docker/pulsar-all/Dockerfile` wasn't the root cause that caused Pulsar 3.0.0 pulsar-all docker images to use the 2.11 image. 
   
   The default build process should have built `apachepulsar/pulsar:latest` locally before the pulsar-all image.
   Perhaps the build dependency isn't working as expected?
   https://github.com/apache/pulsar/blob/bdd1bf1fcabdfc52527d07a8f8a288930e2cb7dd/docker/pulsar-all/pom.xml#L71-L86
   
   We might have to dig deeper.
   
   A possible way to prevent using an old image would be to use a per-build invocation tag instead of using `project.version` alone.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org