You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "chilan204 (via GitHub)" <gi...@apache.org> on 2026/10/21 03:14:53 UTC
[PR] JAMES-4236: Return null for requested nullable JMAP properties [james-project]
chilan204 opened a new pull request, #3263:
URL: https://github.com/apache/james-project/pull/3263
Ensure optional fields in JMAP responses are serialized as explicit null values instead of being omitted, including nested email address names. Preserve existing deserialization behavior and update serialization tests and integration expectations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4236: Return null for requested nullable JMAP properties [james-project]
Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 merged PR #3263:
URL: https://github.com/apache/james-project/pull/3263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4236: Return null for requested nullable JMAP properties [james-project]
Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on code in PR #3263:
URL: https://github.com/apache/james-project/pull/3263#discussion_r4344161915
##########
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/json/MailboxSerializer.scala:
##########
@@ -113,7 +113,7 @@ class MailboxSerializer @Inject()(mailboxIdFactory: MailboxId.Factory) {
mapWrites[QuotaId, Quota](_.getName, quotaWrites)
private implicit val quotasWrites: Writes[Quotas] = Json.valueWrites[Quotas]
- implicit val mailboxWrites: Writes[Mailbox] = Json.writes[Mailbox]
+ implicit val mailboxWrites: Writes[Mailbox] = Json.configured(JsonConfiguration(optionHandlers = OptionHandlers.WritesNull)).writes[Mailbox]
Review Comment:
This is now repeated 9 times across 6 serializers. Maybe a `private[json] val writesNull = Json.configured(JsonConfiguration(optionHandlers = OptionHandlers.WritesNull))` in the json package object, so each place just reads `writesNull.writes[Mailbox]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4236: Return null for requested nullable JMAP properties [james-project]
Posted by "chilan204 (via GitHub)" <gi...@apache.org>.
chilan204 commented on PR #3263:
URL: https://github.com/apache/james-project/pull/3263#issuecomment-6332710627
Just changed the commit prefix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-4236: Return null for requested nullable JMAP properties [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #3263:
URL: https://github.com/apache/james-project/pull/3263#issuecomment-6335453402
https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-3263/4/testReport/org.apache.james.jmap.rfc8621.memory/MemoryMailboxChangesMethodTest/mailboxChangesShouldSupportBackReferenceWithNullUpdatedProperties_GuiceJamesServer_/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org