You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/28 06:50:39 UTC
[GitHub] [spark] LuciferYang opened a new pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
LuciferYang opened a new pull request #34418:
URL: https://github.com/apache/spark/pull/34418
### What changes were proposed in this pull request?
This pr adds all benchmark result files running in Java 17, the file generation uses the same way as SPARK-34950.
### Why are the changes needed?
To have a base line of the benchmarks accordingly.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
It was generated from:
- [Run benchmarks: * (JDK 17)](https://github.com/LuciferYang/spark/actions/runs/1390580580)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34418:
URL: https://github.com/apache/spark/pull/34418#discussion_r739863834
##########
File path: .github/workflows/benchmark.yml
##########
@@ -27,7 +27,7 @@ on:
required: true
default: '*'
jdk:
- description: 'JDK version: 8 or 11'
+ description: 'JDK version: 8, 11 or 17'
Review comment:
Only TPCDSQueryBenchmark-jdk17-results.txt is missing here, and the previous TPCDSQueryBenchmark results are not generated by ｀benchmark｀ GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953659316
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49167/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953552935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953716109
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144698/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953659316
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49167/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953744682
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49174/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953754404
**[Test build #144705 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144705/testReport)** for PR 34418 at commit [`2684d3e`](https://github.com/apache/spark/commit/2684d3eb329356e2d4f9ba86358e1ca7203f383e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `public class NumericHistogram `
* ` * The Coord class defines a histogram bin, which is just an (x,y) pair.`
* ` public static class Coord implements Comparable `
* `case class HistogramNumeric(`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-955832474
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953595537
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49167/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34418:
URL: https://github.com/apache/spark/pull/34418#discussion_r739863834
##########
File path: .github/workflows/benchmark.yml
##########
@@ -27,7 +27,7 @@ on:
required: true
default: '*'
jdk:
- description: 'JDK version: 8 or 11'
+ description: 'JDK version: 8, 11 or 17'
Review comment:
TPCDSQueryBenchmark-jdk17-results.txt is missing here, and the previous TPCDSQueryBenchmar kbenchmark results are not generated by GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34418:
URL: https://github.com/apache/spark/pull/34418#discussion_r739746311
##########
File path: .github/workflows/benchmark.yml
##########
@@ -27,7 +27,7 @@ on:
required: true
default: '*'
jdk:
- description: 'JDK version: 8 or 11'
+ description: 'JDK version: 8, 11 or 17'
Review comment:
@LuciferYang just to clarify, are there more benchmarks to generate results? or are these all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953744682
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49174/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953626001
**[Test build #144705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144705/testReport)** for PR 34418 at commit [`2684d3e`](https://github.com/apache/spark/commit/2684d3eb329356e2d4f9ba86358e1ca7203f383e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953626001
**[Test build #144705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144705/testReport)** for PR 34418 at commit [`2684d3e`](https://github.com/apache/spark/commit/2684d3eb329356e2d4f9ba86358e1ca7203f383e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34418:
URL: https://github.com/apache/spark/pull/34418#discussion_r738904035
##########
File path: .github/workflows/benchmark.yml
##########
@@ -27,7 +27,7 @@ on:
required: true
default: '*'
jdk:
- description: 'JDK version: 8 or 11'
+ description: 'JDK version: 8, 11 or 17'
Review comment:
Are there a lot of works to be done? I think we should update these benchmarks in one go if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34418:
URL: https://github.com/apache/spark/pull/34418#discussion_r738084816
##########
File path: .github/workflows/benchmark.yml
##########
@@ -27,7 +27,7 @@ on:
required: true
default: '*'
jdk:
- description: 'JDK version: 8 or 11'
+ description: 'JDK version: 8, 11 or 17'
Review comment:
I didn't know it already works, lol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34418:
URL: https://github.com/apache/spark/pull/34418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34418:
URL: https://github.com/apache/spark/pull/34418#discussion_r739863834
##########
File path: .github/workflows/benchmark.yml
##########
@@ -27,7 +27,7 @@ on:
required: true
default: '*'
jdk:
- description: 'JDK version: 8 or 11'
+ description: 'JDK version: 8, 11 or 17'
Review comment:
Only TPCDSQueryBenchmark-jdk17-results.txt is missing here, and the previous TPCDSQueryBenchmar kbenchmark results are not generated by ｀benchmark｀ GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34418:
URL: https://github.com/apache/spark/pull/34418#discussion_r738915464
##########
File path: .github/workflows/benchmark.yml
##########
@@ -27,7 +27,7 @@ on:
required: true
default: '*'
jdk:
- description: 'JDK version: 8 or 11'
+ description: 'JDK version: 8, 11 or 17'
Review comment:
Ok, I think we can hold this pr for a period of time and wait until a more appropriate time to update it.
And from the benchmarks result, I find that Java 11 is slower than Java 8 and Java 17 is slower than Java 11 when using the same configuration, which is a little unacceptable ....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953565765
**[Test build #144698 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144698/testReport)** for PR 34418 at commit [`1ab15b9`](https://github.com/apache/spark/commit/1ab15b98f7c7a0f7030b014f3304e9d2d2b2994b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953755747
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144705/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34418:
URL: https://github.com/apache/spark/pull/34418#discussion_r738137694
##########
File path: .github/workflows/benchmark.yml
##########
@@ -27,7 +27,7 @@ on:
required: true
default: '*'
jdk:
- description: 'JDK version: 8 or 11'
+ description: 'JDK version: 8, 11 or 17'
Review comment:
After SPARK-37105, all UTs should passed use Java 17 on linux. Currently, these benchmarks also can run successfully on GA use Java 17, do we need to wait for other key points to complete before updating these benchmark results?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953558048
The result file of `TPCDSQueryBenchmark-jdk17-results.txt` is missing in this pr because I do not have the test resources of AWS EC2 resources now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953755747
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144705/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953714447
**[Test build #144698 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144698/testReport)** for PR 34418 at commit [`1ab15b9`](https://github.com/apache/spark/commit/1ab15b98f7c7a0f7030b014f3304e9d2d2b2994b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953565765
**[Test build #144698 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144698/testReport)** for PR 34418 at commit [`1ab15b9`](https://github.com/apache/spark/commit/1ab15b98f7c7a0f7030b014f3304e9d2d2b2994b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953648275
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49167/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-955875891
thanks all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34418:
URL: https://github.com/apache/spark/pull/34418#discussion_r738151785
##########
File path: .github/workflows/benchmark.yml
##########
@@ -27,7 +27,7 @@ on:
required: true
default: '*'
jdk:
- description: 'JDK version: 8 or 11'
+ description: 'JDK version: 8, 11 or 17'
Review comment:
If we have to wait for other work to complete before updating these results, I can close this PR first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953716109
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144698/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953719585
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49174/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #34418:
URL: https://github.com/apache/spark/pull/34418#discussion_r738151785
##########
File path: .github/workflows/benchmark.yml
##########
@@ -27,7 +27,7 @@ on:
required: true
default: '*'
jdk:
- description: 'JDK version: 8 or 11'
+ description: 'JDK version: 8, 11 or 17'
Review comment:
If we have to wait for other work to complete before updating these results, I can close this pr first, haha ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34418: [SPARK-37129][TESTS] Supplement Java 17 benchmark results created by GitHub Actions machines
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34418:
URL: https://github.com/apache/spark/pull/34418#issuecomment-953674135
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49174/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org